-
Notifications
You must be signed in to change notification settings - Fork 340
Rename serialization methods in DevTools to meet recommended standard. #7584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we revert all the renames in devtools_app_shared
, devtools_extensions
, and devtools_shared
? These are breaking changes that will cause unnecessary churn for users of these packages.
Or another option for these packages is to mark the existing methods deprecated with a message to use the new methods. But this may be overkill for a rename. |
Reverted |
auto label is removed for flutter/devtools/7584, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto label is removed for flutter/devtools/7584, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
https://docs.flutter.dev/data-and-backend/serialization/json#serializing-json-inside-model-classes