Skip to content

Rename serialization methods in DevTools to meet recommended standard. #7584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 15, 2024

Conversation

polina-c
Copy link
Contributor

@polina-c polina-c marked this pull request as ready for review April 15, 2024 17:50
@polina-c polina-c requested review from bkonyi, kenzieschmoll and a team as code owners April 15, 2024 17:50
@polina-c polina-c changed the title Rename serialization methods in Dev Tools to meet recommended standard. Rename serialization methods in DevTools to meet recommended standard. Apr 15, 2024
@polina-c polina-c requested a review from elliette as a code owner April 15, 2024 18:00
Copy link
Member

@kenzieschmoll kenzieschmoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert all the renames in devtools_app_shared, devtools_extensions, and devtools_shared? These are breaking changes that will cause unnecessary churn for users of these packages.

@kenzieschmoll
Copy link
Member

Or another option for these packages is to mark the existing methods deprecated with a message to use the new methods. But this may be overkill for a rename.

@polina-c
Copy link
Contributor Author

Can we revert all the renames in devtools_app_shared, devtools_extensions, and devtools_shared? These are breaking changes that will cause unnecessary churn for users of these packages.

Reverted

@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
Copy link

auto-submit bot commented Apr 15, 2024

auto label is removed for flutter/devtools/7584, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
@polina-c polina-c added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
Copy link

auto-submit bot commented Apr 15, 2024

auto label is removed for flutter/devtools/7584, due to - The status or check suite devtools_app integration-test integration_dart2js - flutter - shard 3/3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@polina-c polina-c merged commit b9ae32e into flutter:master Apr 15, 2024
@polina-c polina-c deleted the offline1 branch April 15, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants