Rename serialization methods in DevTools to meet recommended standard. (#7584)

Author: polina-c

packages/devtools_app/lib/src/example/conditional_screen.dart

@@ -91,7 +91,7 @@ class ExampleController extends DisposableController
     } else {
       await maybeLoadOfflineData(
         ExampleConditionalScreen.id,
-        createData: (json) => ExampleScreenData.parse(json),
+        createData: (json) => ExampleScreenData.fromJson(json),
         shouldLoad: (data) => data.title.isNotEmpty,
       );
     }
@@ -116,7 +116,7 @@ class ExampleController extends DisposableController
 class ExampleScreenData {
   ExampleScreenData(this.title);
 
-  factory ExampleScreenData.parse(Map<String, Object?> json) {
+  factory ExampleScreenData.fromJson(Map<String, Object?> json) {
     return ExampleScreenData(json[_titleKey] as String);
   }
 

packages/devtools_app/lib/src/screens/debugger/span_parser.dart

@@ -43,7 +43,7 @@ class Grammar {
     return Grammar._(
       name: json['name'] as String,
       scopeName: json['scopeName'] as String,
-      topLevelMatcher: GrammarMatcher.parse(json),
+      topLevelMatcher: GrammarMatcher.fromJson(json),
       repository: Repository.build(json),
     );
   }
@@ -168,7 +168,7 @@ class Repository {
       return;
     }
     for (final subRepo in repositoryJson.keys) {
-      matchers[subRepo] = GrammarMatcher.parse(repositoryJson[subRepo]!);
+      matchers[subRepo] = GrammarMatcher.fromJson(repositoryJson[subRepo]!);
     }
   }
 
@@ -183,7 +183,7 @@ class Repository {
 }
 
 abstract class GrammarMatcher {
-  factory GrammarMatcher.parse(Map<String, Object?> json) {
+  factory GrammarMatcher.fromJson(Map<String, Object?> json) {
     if (_IncludeMatcher.isType(json)) {
       return _IncludeMatcher(json['include'] as String);
     } else if (_SimpleMatcher.isType(json)) {
@@ -237,7 +237,7 @@ abstract class GrammarMatcher {
             scanner.substring(0, captureEndLocation.position),
             position: captureStartLocation.position,
           );
-          GrammarMatcher.parse(capture)
+          GrammarMatcher.fromJson(capture)
               .scan(grammar, captureScanner, scopeStack);
         }
 
@@ -302,7 +302,7 @@ class _MultilineMatcher extends GrammarMatcher {
             : RegExp(json['while'] as String, multiLine: true),
         patterns = (json['patterns'] as List<Object?>?)
             ?.cast<Map<String, Object?>>()
-            .map((e) => GrammarMatcher.parse(e))
+            .map((e) => GrammarMatcher.fromJson(e))
             .toList()
             .cast<GrammarMatcher>(),
         super._(json);
@@ -520,7 +520,7 @@ class _PatternMatcher extends GrammarMatcher {
   _PatternMatcher(Map<String, Object?> json)
       : patterns = (json['patterns'] as List<Object?>?)
             ?.cast<Map<String, Object?>>()
-            .map((e) => GrammarMatcher.parse(e))
+            .map((e) => GrammarMatcher.fromJson(e))
             .toList()
             .cast<GrammarMatcher>(),
         super._(json);

packages/devtools_app/lib/src/screens/memory/framework/memory_controller.dart

@@ -97,7 +97,7 @@ class MemoryController extends DisposableController
         assert(connectedDiff == null && connectedProfile == null);
         await maybeLoadOfflineData(
           ScreenMetaData.memory.id,
-          createData: (json) => OfflineMemoryData.parse(json),
+          createData: (json) => OfflineMemoryData.fromJson(json),
           shouldLoad: (data) => true,
         );
         // [maybeLoadOfflineData] will be a noop if there is no offline data for the memory screen,
@@ -147,7 +147,7 @@ class MemoryController extends DisposableController
           chart,
           profile.classFilter.value,
           selectedTab: selectedFeatureTabIndex,
-        ).prepareForOffline(),
+        ).toJson(),
       );
 
   @override

packages/devtools_app/lib/src/screens/memory/framework/offline_data/offline_data.dart

@@ -26,14 +26,14 @@ class OfflineMemoryData {
 
   // TODO(polina-c): use an extension type for the Json parsing, https://github.com/flutter/devtools/issues/6972
   // https://github.com/flutter/devtools/pull/7572#discussion_r1563102256
-  factory OfflineMemoryData.parse(Map<String, dynamic> json) {
+  factory OfflineMemoryData.fromJson(Map<String, dynamic> json) {
     Map<String, dynamic> item(String key) =>
         json[key] as Map<String, dynamic>? ?? {};
     return OfflineMemoryData(
-      DiffPaneController.parse(item(_Json.diffData)),
-      ProfilePaneController.parse(item(_Json.profileData)),
-      MemoryChartPaneController.parse(item(_Json.chartData)),
-      ClassFilter.parse(item(_Json.classFilter)),
+      DiffPaneController.fromJson(item(_Json.diffData)),
+      ProfilePaneController.fromJson(item(_Json.profileData)),
+      MemoryChartPaneController.fromJson(item(_Json.chartData)),
+      ClassFilter.fromJson(item(_Json.classFilter)),
       selectedTab: json[_Json.selectedTab] as int? ?? 0,
     );
   }
@@ -45,13 +45,13 @@ class OfflineMemoryData {
   final ProfilePaneController profile;
   final MemoryChartPaneController chart;
 
-  Map<String, dynamic> prepareForOffline() {
+  Map<String, dynamic> toJson() {
     return {
       _Json.selectedTab: selectedTab,
-      _Json.diffData: diff.prepareForOffline(),
-      _Json.profileData: profile.prepareForOffline(),
-      _Json.chartData: chart.prepareForOffline(),
-      _Json.classFilter: profile.classFilter.value.prepareForOffline(),
+      _Json.diffData: diff.toJson(),
+      _Json.profileData: profile.toJson(),
+      _Json.chartData: chart.toJson(),
+      _Json.classFilter: profile.classFilter.value.toJson(),
     };
   }
 }

packages/devtools_app/lib/src/screens/memory/panes/chart/controller/chart_pane_controller.dart

@@ -83,7 +83,7 @@ class MemoryChartPaneController extends DisposableController
     unawaited(_init());
   }
 
-  factory MemoryChartPaneController.parse(Map<String, dynamic> map) {
+  factory MemoryChartPaneController.fromJson(Map<String, dynamic> map) {
     // TODO(polina-c): implement, https://github.com/flutter/devtools/issues/6972
     return MemoryChartPaneController(
       DevToolsMode.offlineData,
@@ -110,7 +110,7 @@ class MemoryChartPaneController extends DisposableController
     );
   }
 
-  Map<String, dynamic> prepareForOffline() {
+  Map<String, dynamic> toJson() {
     // TODO(polina-c): implement, https://github.com/flutter/devtools/issues/6972
     return {};
   }

packages/devtools_app/lib/src/screens/memory/panes/diff/controller/diff_pane_controller.dart

@@ -31,12 +31,12 @@ import 'item_controller.dart';
 class DiffPaneController extends DisposableController {
   DiffPaneController({required this.loader});
 
-  factory DiffPaneController.parse(Map<String, dynamic> map) {
+  factory DiffPaneController.fromJson(Map<String, dynamic> map) {
     // TODO(polina-c): implement, https://github.com/flutter/devtools/issues/6972
     return DiffPaneController(loader: null);
   }
 
-  Map<String, dynamic> prepareForOffline() {
+  Map<String, dynamic> toJson() {
     // TODO(polina-c): implement, https://github.com/flutter/devtools/issues/6972
     return {};
   }

packages/devtools_app/lib/src/screens/memory/panes/profile/profile_pane_controller.dart

@@ -17,12 +17,12 @@ class ProfilePaneController extends DisposableController
     with AutoDisposeControllerMixin {
   ProfilePaneController();
 
-  factory ProfilePaneController.parse(Map<String, dynamic> map) {
+  factory ProfilePaneController.fromJson(Map<String, dynamic> map) {
     // TODO(polina-c): implement, https://github.com/flutter/devtools/issues/6972
     return ProfilePaneController();
   }
 
-  Map<String, dynamic> prepareForOffline() {
+  Map<String, dynamic> toJson() {
     // TODO(polina-c): implement, https://github.com/flutter/devtools/issues/6972
     return {};
   }

packages/devtools_app/lib/src/screens/memory/shared/heap/class_filter.dart

@@ -64,7 +64,7 @@ class ClassFilter {
           only: null,
         );
 
-  factory ClassFilter.parse(Map<String, dynamic> json) {
+  factory ClassFilter.fromJson(Map<String, dynamic> json) {
     final type = json[_Json.type] as String?;
     return ClassFilter(
       filterType:
@@ -77,7 +77,7 @@ class ClassFilter {
 
   // TODO: use an extension type for the Json parsing, https://github.com/flutter/devtools/issues/6972
   // https://github.com/flutter/devtools/pull/7572#discussion_r1563130198
-  Map<String, dynamic> prepareForOffline() {
+  Map<String, dynamic> toJson() {
     return {
       _Json.type: filterType.name,
       _Json.except: except,

packages/devtools_app/lib/src/screens/performance/panes/controls/enhance_tracing/enhance_tracing_controller.dart

@@ -58,7 +58,8 @@ class EnhanceTracingController extends DisposableController
       (event) {
         if (event.extensionKind == 'Flutter.Frame' &&
             _firstLiveFrameId == null) {
-          _firstLiveFrameId = FlutterFrame.parse(event.extensionData!.data).id;
+          _firstLiveFrameId =
+              FlutterFrame.fromJson(event.extensionData!.data).id;
           // See https://github.com/dart-lang/linter/issues/3801
           // ignore: discarded_futures
           unawaited(_firstFrameEventSubscription!.cancel());

packages/devtools_app/lib/src/screens/performance/panes/flutter_frames/flutter_frame_model.dart

@@ -23,7 +23,7 @@ class FlutterFrame {
     required this.vsyncOverheadTime,
   });
 
-  factory FlutterFrame.parse(Map<String, dynamic> json) {
+  factory FlutterFrame.fromJson(Map<String, dynamic> json) {
     final timeStart = Duration(microseconds: json[startTimeKey]!);
     final timeEnd = timeStart + Duration(microseconds: json[elapsedKey]!);
     final frameTime = TimeRange()
@@ -175,7 +175,7 @@ class FlutterFrame {
   }
 
   FlutterFrame shallowCopy() {
-    return FlutterFrame.parse(json);
+    return FlutterFrame.fromJson(json);
   }
 }
 

packages/devtools_app/lib/src/screens/performance/panes/raster_stats/raster_stats_controller.dart

@@ -37,7 +37,7 @@ class RasterStatsController extends PerformanceFeatureController {
     try {
       final response = await serviceConnection.renderFrameWithRasterStats;
       final json = response?.json ?? <String, Object?>{};
-      final rasterStats = RasterStats.parse(json);
+      final rasterStats = RasterStats.fromJson(json);
       setData(rasterStats);
     } catch (e, st) {
       _log.shout('Error collecting raster stats: $e', e, st);

packages/devtools_app/lib/src/screens/performance/panes/raster_stats/raster_stats_model.dart

@@ -15,7 +15,7 @@ class RasterStats {
     required this.selectedSnapshot,
   });
 
-  factory RasterStats.parse(Map<String, Object?> json) {
+  factory RasterStats.fromJson(Map<String, Object?> json) {
     Size? originalFrameSize;
     final originalWidth = json[_frameWidthKey] as num?;
     final originalHeight = json[_frameHeightKey] as num?;
@@ -37,7 +37,7 @@ class RasterStats {
     final snapshots = <LayerSnapshot>[];
     var totalRasterTime = Duration.zero;
     for (final snapshotJson in snapshotsFromJson) {
-      final layerSnapshot = LayerSnapshot.parse(snapshotJson);
+      final layerSnapshot = LayerSnapshot.fromJson(snapshotJson);
       snapshots.add(layerSnapshot);
       totalRasterTime += layerSnapshot.duration;
       if (layerSnapshot.id == selectedId) {
@@ -105,7 +105,7 @@ class LayerSnapshot {
     required this.bytes,
   });
 
-  factory LayerSnapshot.parse(Map<String, Object?> json) {
+  factory LayerSnapshot.fromJson(Map<String, Object?> json) {
     final id = json[_layerIdKey] as int;
     final dur = Duration(microseconds: json[_durationKey] as int);
     final size = Size(

packages/devtools_app/lib/src/screens/performance/panes/rebuild_stats/rebuild_stats_model.dart

@@ -175,7 +175,7 @@ class LocationMap {
 class RebuildCountModel {
   RebuildCountModel();
 
-  RebuildCountModel.parse(Map<String, Object?> json) {
+  RebuildCountModel.fromJson(Map<String, Object?> json) {
     if (json.isEmpty) return;
     locationMap.processLocationMap(json[_locationsKey] as Map<String, Object?>);
     final frames =

packages/devtools_app/lib/src/screens/performance/performance_controller.dart

@@ -125,7 +125,7 @@ class PerformanceController extends DisposableController
             .serviceManager.service!.onExtensionEventWithHistorySafe
             .listen((event) {
           if (event.extensionKind == 'Flutter.Frame') {
-            final frame = FlutterFrame.parse(event.extensionData!.data);
+            final frame = FlutterFrame.fromJson(event.extensionData!.data);
             enhanceTracingController.assignStateForFrame(frame);
             flutterFramesController.addFrame(frame);
           } else if (event.extensionKind == 'Flutter.RebuiltWidgets' &&
@@ -149,7 +149,7 @@ class PerformanceController extends DisposableController
         PerformanceScreen.id,
         // TODO(kenz): make sure DevTools exports can be loaded into the full
         // Perfetto trace viewer (ui.perfetto.dev).
-        createData: (json) => OfflinePerformanceData.parse(json),
+        createData: (json) => OfflinePerformanceData.fromJson(json),
         shouldLoad: (data) => !data.isEmpty,
       );
     }

packages/devtools_app/lib/src/screens/performance/performance_model.dart

@@ -23,7 +23,7 @@ class OfflinePerformanceData {
     double? displayRefreshRate,
   }) : displayRefreshRate = displayRefreshRate ?? defaultRefreshRate;
 
-  factory OfflinePerformanceData.parse(Map<String, Object?> json_) {
+  factory OfflinePerformanceData.fromJson(Map<String, Object?> json_) {
     final json = _PerformanceDataJson(json_);
 
     final selectedFrameId = json.selectedFrameId;
@@ -83,7 +83,7 @@ extension type _PerformanceDataJson(Map<String, Object?> json) {
   RasterStats? get rasterStats {
     final raw = (json[OfflinePerformanceData.rasterStatsKey] as Map? ?? {})
         .cast<String, Object>();
-    return raw.isNotEmpty ? RasterStats.parse(raw) : null;
+    return raw.isNotEmpty ? RasterStats.fromJson(raw) : null;
   }
 
   int? get selectedFrameId =>
@@ -93,7 +93,7 @@ extension type _PerformanceDataJson(Map<String, Object?> json) {
       (json[OfflinePerformanceData.flutterFramesKey] as List? ?? [])
           .cast<Map>()
           .map((f) => f.cast<String, dynamic>())
-          .map((f) => FlutterFrame.parse(f))
+          .map((f) => FlutterFrame.fromJson(f))
           .toList();
 
   double get displayRefreshRate =>
@@ -105,7 +105,7 @@ extension type _PerformanceDataJson(Map<String, Object?> json) {
     final raw =
         (json[OfflinePerformanceData.rebuildCountModelKey] as Map? ?? {})
             .cast<String, dynamic>();
-    return raw.isNotEmpty ? RebuildCountModel.parse(raw) : null;
+    return raw.isNotEmpty ? RebuildCountModel.fromJson(raw) : null;
   }
 }
 

packages/devtools_app/lib/src/screens/profiler/cpu_profile_model.dart

@@ -168,7 +168,7 @@ class CpuProfileData {
     _cpuProfileRoot = CpuStackFrame.root(profileMetaData);
   }
 
-  factory CpuProfileData.parse(Map<String, dynamic> json_) {
+  factory CpuProfileData.fromJson(Map<String, dynamic> json_) {
     final json = _CpuProfileDataJson(json_);
     final profileMetaData = CpuProfileMetaData(
       sampleCount: json.sampleCount ?? 0,
@@ -529,7 +529,7 @@ class CpuProfileData {
     );
   }
 
-  factory CpuProfileData.empty() => CpuProfileData.parse({});
+  factory CpuProfileData.empty() => CpuProfileData.fromJson({});
 
   /// Generates [CpuProfileData] from the provided [CpuSamples].
   ///
@@ -586,7 +586,7 @@ class CpuProfileData {
 
     await _addPackageUrisToTraceObject(isolateId, traceObject);
 
-    return CpuProfileData.parse(traceObject);
+    return CpuProfileData.fromJson(traceObject);
   }
 
   /// Helper function for determining and updating the
@@ -769,7 +769,7 @@ extension type _CpuProfileDataJson(Map<String, dynamic> json) {
       (json[CpuProfileData._traceEventsKey] as List?)
           ?.cast<Map>()
           .map((trace) => trace.cast<String, Object?>())
-          .map((trace) => CpuSampleEvent.parse(trace))
+          .map((trace) => CpuSampleEvent.fromJson(trace))
           .toList()
           .cast<CpuSampleEvent>();
 }
@@ -809,7 +809,7 @@ class CpuSampleEvent extends ChromeTraceEvent {
     required Map<String, dynamic> traceJson,
   }) : super(traceJson);
 
-  factory CpuSampleEvent.parse(Map<String, dynamic> traceJson) {
+  factory CpuSampleEvent.fromJson(Map<String, dynamic> traceJson) {
     final leafId = traceJson[CpuProfileData.stackFrameIdKey];
     final args =
         (traceJson[ChromeTraceEvent.argsKey] as Map?)?.cast<String, Object?>();
@@ -913,7 +913,7 @@ class CpuStackFrame extends TreeNode<CpuStackFrame>
 
   final String? parentId;
 
-  /// The set of ids for all ancesctors of this [CpuStackFrame].
+  /// The set of ids for all ancestors of this [CpuStackFrame].
   ///
   /// This is late and final, so it will only be created once for performance
   /// reasons. This method should only be called when the [CpuStackFrame] is

packages/devtools_app/lib/src/screens/profiler/profiler_screen_controller.dart

@@ -80,7 +80,7 @@ class ProfilerScreenController extends DisposableController
     } else {
       await maybeLoadOfflineData(
         ProfilerScreen.id,
-        createData: (json) => CpuProfileData.parse(json),
+        createData: (json) => CpuProfileData.fromJson(json),
         shouldLoad: (data) => !data.isEmpty,
       );
     }