fix(ab): do not crash during printing of dimensions #5189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
added
the
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5189 +/- ##
==========================================
+ Coverage 82.88% 82.93% +0.05%
==========================================
Files 250 250
Lines 26936 26936
==========================================
+ Hits 22325 22339 +14
+ Misses 4611 4597 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ShadowCurse
reviewed
May 6, 2025
`dimension_set` is a frozenset of tuples, not a dictionary, so no need to call .items() (which in fact doesnt even exist), and converting a dictionary comprehention expresson into a dictionary with an explicit call to dict() is also unnecessary. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
force-pushed
the
ab-do-not-crash-during-printing
branch
from
830b3dd to
96ade74
Compare
ShadowCurse
approved these changes
May 6, 2025
bchalios
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
dimension_setis a frozenset of tuples, not a dictionary, so no needto call .items() (which in fact doesnt even exist), and converting a
dictionary comprehention expresson into a dictionary with an explicit
call to dict() is also unnecessary.
Reason
...
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.