Skip to content

Commit 830b3dd

Browse files
committed
fix(ab): do not crash during printing of dimensions
the argument I passed to json.dumps was just wrong in so many ways Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
1 parent 41fb776 commit 830b3dd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tools/ab_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -327,7 +327,7 @@ def analyze_data(
327327
f"for metric \033[1m{metric}\033[0m with \033[0;31m\033[1mp={result.pvalue}\033[0m. "
328328
f"This means that observing a change of this magnitude or worse, assuming that performance "
329329
f"characteristics did not change across the tested commits, has a probability of {result.pvalue:.2%}. "
330-
f"Tested Dimensions:\n{json.dumps(dict({k: v for k,v in dimension_set.items() if k not in do_not_print_list}), indent=2, sort_keys=True)}"
330+
f"Tested Dimensions:\n{json.dumps({k: v for k,v in dimension_set if k not in do_not_print_list}, indent=2, sort_keys=True)}"
331331
)
332332
messages.append(msg)
333333

0 commit comments

Comments
 (0)