Tracing filter #3971
Closed
Tracing filter #3971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
force-pushed
the
tracing-final
branch
11 times, most recently
from
b280f78 to
07ee5c5
Compare
JonathanWoollett-Light
added
Priority: Medium
JonathanWoollett-Light
force-pushed
the
tracing-final
branch
14 times, most recently
from
201fd3d to
77e333b
Compare
JonathanWoollett-Light
force-pushed
the
tracing-final
branch
13 times, most recently
from
041ab1a to
05f8294
Compare
|
Blocked on #3808 |
JonathanWoollett-Light
added
Status: Blocked
Closed
9 tasks
JonathanWoollett-Light
force-pushed
the
tracing-final
branch
4 times, most recently
from
d82168a to
d6870c1
Compare
Re-exports logging macros from `logger` to allow more atomic changes in `logger`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
tracing-final
branch
from
d6870c1 to
1f38791
Compare
added 2 commits
August 18, 2023 11:28
Replaces `log` with `tracing` and the custom logger with `tracing_subscriber::Fmt`. Adding support for re-configuring the logger at run-time and removing the old logger format. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Add the ` FilterFn` layer to support filtering by crates, modules and spans. With `tracing::instrument` spans wrap functions, this would support filtering to specific functions. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
tracing-final
branch
from
1f38791 to
5ae77b7
Compare
|
Moved to feature branch to store work for historical reference https://github.com/firecracker-microvm/firecracker/tree/feature/tokio-tracing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add the
FilterFnlayer to support filtering by crate, module and span.With
tracing::instrumentspans wrap functions, this wouldsupport filtering to specific functions.
Reason
...
Status
Passes all tests except
test_api_requests_logs. If the filter function is simply changed to always returntrueit passes this test, implying the issue relates to the filter being incorrect. I was thinking the filter level doesn't get updated from the default (Warn) toInfoin time to print the log message, but adding a timeout between the API request to update the log level and the following API request where it expects to see the log doesn't appear to make any difference.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.