-
Notifications
You must be signed in to change notification settings - Fork 2k
Tracing instrument #3810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing instrument #3810
Conversation
Blocked on #3808 |
9ab22a0
to
8804768
Compare
8804768
to
65566c7
Compare
aabca1a
to
3b48ad6
Compare
3ad2277
to
64082ef
Compare
64082ef
to
c2dd5d9
Compare
8c27615
to
cee16ee
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3810 +/- ##
===========================================
- Coverage 82.66% 71.07% -11.60%
===========================================
Files 221 219 -2
Lines 28192 9084 -19108
===========================================
- Hits 23306 6456 -16850
+ Misses 4886 2628 -2258
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
3c5d953
to
e1697a3
Compare
Re-exports logging macros from `logger` to allow more atomic changes in `logger`. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
e1697a3
to
2031800
Compare
Replaces `log` with `tracing` and the custom logger with `tracing_subscriber::Fmt`. Adding support for re-configuring the logger at run-time and removing the old logger format. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Add the ` FilterFn` layer to support filtering by crates, modules and spans. With `tracing::instrument` spans wrap functions, this would support filtering to specific functions. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Adds code instrumentation. This opens support for tracing and profiling via this instrumentation. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Runs `clippy-tracing --check` to assert code is properly instrumented. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
Enables the `max_level_debug` tracing features to omit instrumentation by default. Signed-off-by: Jonathan Woollett-LIght <jcawl@amazon.co.uk>
2031800
to
40f5eaa
Compare
Moved to feature branch to store work for historical reference https://github.com/firecracker-microvm/firecracker/tree/feature/tokio-tracing. |
Changes
Adds code instrumentation.
Reason
This opens support for tracing and profiling via this instrumentation.
skip_all
is avoided as it is removed in the latest version oftracing
, while we can use it here, it would need to be removed later.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
CHANGELOG.md
.TODO
s link to an issue.rust-vmm
.