eth/catalyst: implement getBlobsV2 #31791
Conversation
MariusVanDerWijden
requested review from
fjl,
rjl493456442,
lightclient,
jwasinger and
gballet
as code owners
MariusVanDerWijden
changed the title
MariusVanDerWijden
force-pushed
the
peerdas-devnet-7
branch
from
ff6e518 to
c192c9d
Compare
| log.Warn("Encountered Version 0 transaction post-Osaka, recompute proofs", "hash", ltx.Hash) | ||
| sidecar.Proofs = make([]kzg4844.Proof, 0) | ||
| for _, blob := range sidecar.Blobs { | ||
| cellProofs, err := kzg4844.ComputeCells(&blob) |
There was a problem hiding this comment.
When we pass the fork, as long as the prioritized blob transactions are v0, we will be computing cell proofs for each bob they contain.
I've benchmarked this and it's pretty slow: 200-300ms depending on the machine (i've tested my m2 mbp and a server machine I'm using to run a perfnet node).
Might be safer to just disallow mining v0 transactions after we've passed the fork , and also purge them from the blobpool.
There was a problem hiding this comment.
Yes that is kinda expected. Other clients are just dropping the transactions, but I think we should recompute the proofs. Its still within the limits that we can do it for a bit and only the block producing machine will have to do it. I think we should take the high route and not invalidate the valid transactions at the fork point
There was a problem hiding this comment.
As part of this PR, we will need to update the billy shelf "slotter" to consider the size of cell proofs after the fork. I'm not sure how complex it would be to accommodate both v0/v1 transactions, but IMO it helps support the case for purging v0 transactions at the fork block.
Implements
engine_getBlobsV2which is needed for PeerDAS