Add Unified EL metrics for GetBlobsV2 #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mininny
reviewed
May 14, 2025
eth/catalyst/api.go
Outdated
| // Number of blobs requested via getBlobsV2 | ||
| getBlobsV2BlobsRequestedTotal = metrics.NewRegisteredCounter("get_blobs_requests_blobs_total", nil) | ||
| // Number of blobs requested via getBlobsV2 that are present in the blobpool | ||
| getBlobsV2BlobsInPoolTottal = metrics.NewRegisteredCounter("get_blobs_requests_blobs_in_blobpool_total", nil) |
There was a problem hiding this comment.
Suggested change
| getBlobsV2BlobsInPoolTottal = metrics.NewRegisteredCounter("get_blobs_requests_blobs_in_blobpool_total", nil) | |
| getBlobsV2BlobsInPoolTotal = metrics.NewRegisteredCounter("get_blobs_requests_blobs_in_blobpool_total", nil) |
minor typo here
|
Could you open this against #63? |
Hi @MariusVanDerWijden, |
|
Sorry I posted the wrong branch, I meant this PR: ethereum#31791 |
|
Closing this PR as requested by @MariusVanDerWijden. I’ll reopen it directly against upstream PR ethereum#31791. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unified metrics across different ELs for the new GetBlobsV2 Engine API that is WIP in PR #63.
I've been working on implementing these metrics across different ELs with Minhyuk from Sunnyside Labs. This is initiated to gather something in common between ELs for devnet tests. You can find our proposal here https://testinprod.notion.site/Proposal-for-Unified-EL-metrics-for-PeerDAS-1d28fc57f54680f2a3cbfe408d7db4b8?pvs=4.