Skip to content

chore(ci): bump prague to stable and osaka to develop #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/configs/feature.yaml
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
# Unless filling for special features, all features should fill for previous forks (starting from Frontier) too
stable:
evm-type: stable
fill-params: --until=Cancun
fill-params: --until=Prague
solc: 0.8.21
develop:
evm-type: develop
fill-params: --until=Prague
fill-params: --until=Osaka
solc: 0.8.21
static:
evm-type: static
fill-params: --until=Prague --fill-static-tests ./tests/static
fill-params: --until=Osaka --fill-static-tests ./tests/static
solc: 0.8.21
benchmark_30M:
evm-type: benchmark
Expand Down
5 changes: 5 additions & 0 deletions docs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Test fixtures for use by clients are available for each release on the [Github r
### 💥 Breaking Changes

- Python 3.10 support was removed in this release ([#1808](https://github.com/ethereum/execution-spec-tests/pull/1808)).
- Tests for the Prague fork are now marked as stable will be included in the `fixtures_stable.tar.gz` tarball from now on.
- Tests for the Osaka fork are now included in the `fixtures_develop.tar.gz` tarball.

#### 💥 Important Change for `fill` Users

Expand Down Expand Up @@ -80,6 +82,7 @@ Users can select any of the artifacts depending on their testing needs for their
- 🔀 Refactor and clean up of exceptions including EOF exceptions within client specific mappers [#1803](https://github.com/ethereum/execution-spec-tests/pull/1803).
- 🔀 Rename `tests/zkevm/` to `tests/benchmark/` and replace the `zkevm` pytest mark with `benchmark` [#1804](https://github.com/ethereum/execution-spec-tests/pull/1804).
- 🔀 Add fixture comparison check to optimize coverage workflow in CI ([#1833](https://github.com/ethereum/execution-spec-tests/pull/1833)).
- 🔀 Move Prague to stable and Osaka to develop ([#1573](https://github.com/ethereum/execution-spec-tests/pull/1573)).

### 🧪 Test Cases

Expand Down Expand Up @@ -600,8 +603,10 @@ The following changes may be potentially breaking (all clients were tested with
- 💥 "Merge" has been renamed to "Paris" in the "network" field of the Blockchain tests, and in the "post" field of the State tests ([#480](https://github.com/ethereum/execution-spec-tests/pull/480)).
- ✨ Port entry point scripts to use [click](https://click.palletsprojects.com) and add tests ([#483](https://github.com/ethereum/execution-spec-tests/pull/483)).
- 💥 As part of the pydantic conversion, the fixtures have the following (possibly breaking) changes ([#486](https://github.com/ethereum/execution-spec-tests/pull/486)):

- State test field `transaction` now uses the proper zero-padded hex number format for fields `maxPriorityFeePerGas`, `maxFeePerGas`, and `maxFeePerBlobGas`.
- Fixtures' hashes (in the `_info` field) are now calculated by removing the "_info" field entirely instead of it being set to an empty dict.

- 🐞 Relax minor and patch dependency requirements to avoid conflicting package dependencies ([#510](https://github.com/ethereum/execution-spec-tests/pull/510)).
- 🔀 Update all CI actions to use their respective Node.js 20 versions, ahead of their Node.js 16 version deprecations ([#527](https://github.com/ethereum/execution-spec-tests/pull/527)).
- ✨ Releases now contain a `fixtures_eip7692.tar.gz` which contains all EOF fixtures ([#573](https://github.com/ethereum/execution-spec-tests/pull/573)).
Expand Down
8 changes: 0 additions & 8 deletions src/ethereum_test_forks/forks/forks.py
Original file line number Diff line number Diff line change
Expand Up @@ -1123,14 +1123,6 @@ class Prague(Cancun):
"BLOB_BASE_FEE_UPDATE_FRACTION": 5007716,
}

@classmethod
def is_deployed(cls) -> bool:
"""
Flag that the fork has not been deployed to mainnet; it is under active
development.
"""
return False

@classmethod
def solc_min_version(cls) -> Version:
"""Return minimum version of solc that supports this fork."""
Expand Down
6 changes: 3 additions & 3 deletions src/ethereum_test_forks/tests/test_forks.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,9 @@
from ..transition_base_fork import transition_fork

FIRST_DEPLOYED = Frontier
LAST_DEPLOYED = Cancun
LAST_DEVELOPMENT = Prague
DEVELOPMENT_FORKS = [Prague]
LAST_DEPLOYED = Prague
LAST_DEVELOPMENT = Osaka
DEVELOPMENT_FORKS = [Osaka]


def test_transition_forks():
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ commands =


[forks]
develop = Prague
develop = Osaka
eip7692 = EOFv1

[testenv:tests-deployed]
Expand Down
Loading