-
Notifications
You must be signed in to change notification settings - Fork 153
chore(ci): bump prague to stable and osaka to develop #1573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Actually requires #1508 if we want to wait for the last Prague-as-develop release. |
3b9397c
to
05f02d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a couple of requests:
- We need to remove the
is_deployed
method from Prague insrc/ethereum_test_forks/forks/forks.py
. - This is a breaking change in the changelog.
05f02d1
to
8d3f30b
Compare
Made the fixes for this, but some unit tests are failing, particularly the |
07867bb
to
214e430
Compare
d3e7cbc
to
1f75234
Compare
@marioevz @spencer-tb I think we need to get this merged, cf #1856. It's going to make our ci v slow 😢 I just rebased on main, I think we'll have some tests to fix. |
Looking at just now! |
Didn't quite get there but these are the remaining tests to be fixed. Can continue next week. tests/prague/eip6110_deposits/test_modified_contract.py:
tests/prague/eip7702_set_code_tx/test_set_code_txs_2.py:
|
🗒️ Description
Bumps Prague to stable and Osaka to develop in our CI.
Allows us to create an Osaka full release after merging this where
fixtures_stable
would contain Prague andfixtures_develop
up to Osaka (refill-ing all our existing tests).🔗 Related Issues
Requires #1507 and #1454.
✅ Checklist