Skip to content

chore(ci): bump prague to stable and osaka to develop #1573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented May 7, 2025

🗒️ Description

Bumps Prague to stable and Osaka to develop in our CI.

Allows us to create an Osaka full release after merging this where fixtures_stable would contain Prague and fixtures_develop up to Osaka (refill-ing all our existing tests).

🔗 Related Issues

Requires #1507 and #1454.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added scope:ci Scope: Continuous Integration type:chore Type: Chore fork:prague Prague hardfork fork:osaka Osaka hardfork labels May 7, 2025
@spencer-tb spencer-tb marked this pull request as ready for review May 7, 2025 16:15
@marioevz
Copy link
Member

marioevz commented May 9, 2025

Actually requires #1508 if we want to wait for the last Prague-as-develop release.

@spencer-tb spencer-tb force-pushed the spencer-tb/move-prague-to-stable branch 2 times, most recently from 3b9397c to 05f02d1 Compare May 15, 2025 13:48
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a couple of requests:

  • We need to remove the is_deployed method from Prague in src/ethereum_test_forks/forks/forks.py.
  • This is a breaking change in the changelog.

@marioevz marioevz force-pushed the spencer-tb/move-prague-to-stable branch from 05f02d1 to 8d3f30b Compare May 20, 2025 20:06
@marioevz
Copy link
Member

Made the fixes for this, but some unit tests are failing, particularly the src/cli/gentest/tests/test_cli.py unit tests are failing in Prague due to the branch currently being used, which fails to fill if the environment's block number is not 1.

@spencer-tb spencer-tb force-pushed the spencer-tb/move-prague-to-stable branch 2 times, most recently from 07867bb to 214e430 Compare July 1, 2025 16:06
@danceratopz danceratopz force-pushed the spencer-tb/move-prague-to-stable branch from d3e7cbc to 1f75234 Compare July 3, 2025 22:07
@danceratopz
Copy link
Member

@marioevz @spencer-tb I think we need to get this merged, cf #1856. It's going to make our ci v slow 😢

I just rebased on main, I think we'll have some tests to fix.

@spencer-tb
Copy link
Contributor Author

Looking at just now!

@spencer-tb
Copy link
Contributor Author

spencer-tb commented Jul 4, 2025

Looking at just now!

Didn't quite get there but these are the remaining tests to be fixed. Can continue next week.

tests/prague/eip6110_deposits/test_modified_contract.py:

  • test_invalid_layout
  • test_invalid_log_length

tests/prague/eip7702_set_code_tx/test_set_code_txs_2.py:

  • test_delegation_replacement_call_previous_contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork fork:prague Prague hardfork scope:ci Scope: Continuous Integration type:chore Type: Chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants