Skip to content

chore(all): move eof from osaka to unscheduled #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

spencer-tb
Copy link
Contributor

@spencer-tb spencer-tb commented Apr 29, 2025

🗒️ Description

As upset as I am with the decision, I am ripping the band-aid off fast. I hope we can include EOF in a future fork.

I've created a new folder within tests/ called unscheduled. This will contain tests for features that are not currently CFI'd for future forks. Verkle will sit here in the near future too.

I've created a new fork called EOFv1 for simplicity. This should be the only breaking change for filling and consuming existing EOF fixtures. Thus clients will need to add this fork. Evmone should additionally add this fork to fill the EOF tests.

A new label is added to EEST called fork:eof. I will relabel all the existing EOF PRs and issues with this.

🔗 Related Issues

ethereum/EIPs#9703
ethereum/pm#1499

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added type:chore Type: Chore type:refactor Type: Refactor fork:osaka Osaka hardfork feature:eof labels Apr 29, 2025
@spencer-tb spencer-tb marked this pull request as ready for review April 29, 2025 16:30
@winsvega
Copy link
Contributor

winsvega commented Apr 29, 2025

Perhaps it even better in root folder test_research

And it is not included in Osaka yet?

@spencer-tb spencer-tb force-pushed the spencer-tb/sad-remove-eof-from-osaka-sad branch 2 times, most recently from 5ab50b7 to 575e970 Compare May 7, 2025 16:07
Copy link
Member

@danceratopz danceratopz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting on this! I like the addition of the new EOFv1 class and the fact we can leave the 7702 EOF tests are handled so nicely using this fork.

I'm not fond of speculative and would go for unscheduled.

How about potentially two new directories?

  1. ./tests/unscheduled/
  2. ./tests/cfi/

But perhaps CFId is too transitory to get its own folder and will lead to too much moving of files. Either way, I'd be in favor of moving ./tests/osaka/eip7692_eof_v1 to ./tests/unscheduled/.

@spencer-tb spencer-tb force-pushed the spencer-tb/sad-remove-eof-from-osaka-sad branch from 51765cc to ca213f5 Compare May 8, 2025 15:12
@spencer-tb
Copy link
Contributor Author

Thanks for getting on this! I like the addition of the new EOFv1 class and the fact we can leave the 7702 EOF tests are handled so nicely using this fork.

I'm not fond of speculative and would go for unscheduled.

How about potentially two new directories?

1. `./tests/unscheduled/`

2. `./tests/cfi/`

But perhaps CFId is too transitory to get its own folder and will lead to too much moving of files. Either way, I'd be in favor of moving ./tests/osaka/eip7692_eof_v1 to ./tests/unscheduled/.

Changed to tests/unscheduled! Thanks for the suggestion too @winsvega!

@spencer-tb spencer-tb changed the title chore(all): move eof from osaka to speculative chore(all): move eof from osaka to unscheduled May 8, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@marioevz marioevz merged commit 3131f66 into main May 12, 2025
22 checks passed
@marioevz marioevz deleted the spencer-tb/sad-remove-eof-from-osaka-sad branch May 12, 2025 19:01
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
codeofcarson pushed a commit to codeofcarson/execution-spec-tests that referenced this pull request Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:eof fork:osaka Osaka hardfork type:chore Type: Chore type:refactor Type: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants