-
Notifications
You must be signed in to change notification settings - Fork 153
chore(all): move eof from osaka to unscheduled #1507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Perhaps it even better in root folder test_research And it is not included in Osaka yet? |
5ab50b7
to
575e970
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting on this! I like the addition of the new EOFv1
class and the fact we can leave the 7702 EOF tests are handled so nicely using this fork.
I'm not fond of speculative
and would go for unscheduled
.
How about potentially two new directories?
./tests/unscheduled/
./tests/cfi/
But perhaps CFId is too transitory to get its own folder and will lead to too much moving of files. Either way, I'd be in favor of moving ./tests/osaka/eip7692_eof_v1
to ./tests/unscheduled/
.
51765cc
to
ca213f5
Compare
Changed to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😢
🗒️ Description
As upset as I am with the decision, I am ripping the band-aid off fast. I hope we can include EOF in a future fork.
I've created a new folder within
tests/
calledunscheduled
. This will contain tests for features that are not currently CFI'd for future forks. Verkle will sit here in the near future too.I've created a new fork called
EOFv1
for simplicity. This should be the only breaking change for filling and consuming existing EOF fixtures. Thus clients will need to add this fork. Evmone should additionally add this fork to fill the EOF tests.A new label is added to EEST called
fork:eof
. I will relabel all the existing EOF PRs and issues with this.🔗 Related Issues
ethereum/EIPs#9703
ethereum/pm#1499
✅ Checklist