Remove isar steps #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

mrica-equinor merged 12 commits into equinor:main from mrica-equinor:remove-steps

Oct 11, 2024

Contributor

mrica-equinor commented Oct 7, 2024

No description provided.

oysand reviewed

View reviewed changes

src/robot_interface/robot_interface.py Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/isar/apis/models/models.py Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/robot_interface/robot_interface.py Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/robot_interface/robot_interface.py Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/isar/state_machine/states/monitor.py Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/isar/state_machine/states/monitor.py Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/robot_interface/robot_interface.py Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/robot_interface/models/mission/task.py Outdated Show resolved Hide resolved

oysand reviewed

View reviewed changes

src/robot_interface/robot_interface.py Outdated Show resolved Hide resolved

mrica-equinor force-pushed the remove-steps branch 3 times, most recently from 15e7c47 to 2165274 Compare

October 10, 2024 07:38

mrica-equinor added 6 commits

October 10, 2024 09:41


          Remove isar steps

e7bbe9b


          Create TaskType string enum

461c0d9


          Simplify get inspections function

a92c687


          Remove mission status from robot interface

d44f0f9


          Rename stepwise mission to by task mission

5cc5338


          Improve monitor.py

33cb25e

mrica-equinor force-pushed the remove-steps branch from 2165274 to 23d979d Compare

October 10, 2024 07:42

mrica-equinor added 2 commits

October 10, 2024 10:48


          Fix tests

e384e61


          Rename get_inspections to singular

696eb73

mrica-equinor force-pushed the remove-steps branch 3 times, most recently from d5cebfb to 2c3ac8c Compare

October 10, 2024 09:28


          Fix mypy

088fe0b

mrica-equinor force-pushed the remove-steps branch from 2c3ac8c to 088fe0b Compare

October 10, 2024 09:53

mrica-equinor changed the title ~~WIP: Remove steps~~ Remove isar steps

mrica-equinor marked this pull request as ready for review

October 10, 2024 09:55

oysand reviewed

View reviewed changes

src/isar/state_machine/state_machine.py Outdated Show resolved Hide resolved


          Fix metadata received from flotilla

174a2b7

mrica-equinor force-pushed the remove-steps branch from 6230f2a to 174a2b7 Compare

October 10, 2024 10:47

Christdej requested changes

View reviewed changes

Contributor

Christdej left a comment

See comments, also not ideal that ReturnToHome task is used as a DriveToTask. Will allow it, but a DriveToTask could be created or tests / functionallity that wants to DriveTo as pose could be removed.

src/isar/state_machine/state_machine.py Outdated Show resolved Hide resolved

src/robot_interface/robot_interface.py Outdated Show resolved Hide resolved

src/isar/apis/models/start_mission_definition.py Show resolved Hide resolved

src/isar/apis/schedule/scheduling_controller.py Show resolved Hide resolved

tests/isar/state_machine/test_state_machine.py Outdated Show resolved Hide resolved

tests/isar/state_machine/test_state_machine.py Outdated Show resolved Hide resolved

tests/isar/models/example_mission_definition.json Show resolved Hide resolved

Eddasol reviewed

View reviewed changes

src/robot_interface/robot_interface.py Outdated Show resolved Hide resolved

Eddasol reviewed

View reviewed changes

src/robot_interface/robot_interface.py Outdated Show resolved Hide resolved

Eddasol reviewed

View reviewed changes

src/isar/apis/models/start_mission_definition.py Show resolved Hide resolved


          Improve code quality

912f492

mrica-equinor force-pushed the remove-steps branch from 69e346d to 912f492 Compare

October 11, 2024 10:41


          Depricate drive to endpoint

5e389cc

Christdej approved these changes

View reviewed changes

Contributor

Christdej left a comment

LGTM

mrica-equinor merged commit 704165d into equinor:main

6 checks passed

This was referenced Oct 14, 2024

Improve how SignalR sends messages from backend to frontend equinor/flotilla#1761

Closed

ISAR should only focus on Tasks. Steps should be delegated to the translational layers #612

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet