Skip to content

Use l2cap signaling when LeConnUpdate is not available #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use l2cap signaling when LeConnUpdate is not available #411

wants to merge 3 commits into from

Conversation

HaoboGu
Copy link
Collaborator

@HaoboGu HaoboGu commented Jun 18, 2025

fixes #338

HaoboGu added 2 commits June 18, 2025 12:02
@HaoboGu
feat(l2cap): add LeConnParamUpdateReq types
3e210ee 
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
feat(host): use L2CAP signaling when conn parameter update procedure …
91b0368 
…is not supported

Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu
Copy link
Collaborator Author

HaoboGu commented Jun 18, 2025 •
edited
Loading

LeReadRemoteFeatures is not added because I have yet because I have no idea about how to get the result of LeReadRemoteFeatures, which is a LeReadRemoteFeaturesComplete event.

And, there is Read Remote Supported Features command, I'm not sure which one should be used

@HaoboGu
Copy link
Collaborator Author

HaoboGu commented Jun 18, 2025

Another weird thing is, when acting as central, LeReadLocalSupportedFeatures cmd still returns supports_conn_parameters_request_procedure = false. But using LeConnUpdate to update the connection parameters runs well, so I add the role == LeConnRole::Central condition. Maybe I somehow misunderstood the spec, but it works for now.

@HaoboGu HaoboGu mentioned this pull request Jun 18, 2025
Draft
lulf
lulf reviewed Jun 19, 2025
View reviewed changes
@HaoboGu
refactor(host): change next_request_id back to private, remove code…
d20905f 
… which won't be implemented now

Signed-off-by: Haobo Gu <haobogu@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lulf lulf lulf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BleHost(Disconnected) when setting connection param
2 participants
@HaoboGu @lulf