Skip to content

Fix error when setting connection param #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 1, 2025
Merged

Fix error when setting connection param #419

merged 8 commits into from
Jul 1, 2025

Conversation

HaoboGu
Copy link
Owner

@HaoboGu HaoboGu commented Jun 18, 2025

Upstream PR: embassy-rs/trouble#411

Copy link

github-actions bot commented Jun 18, 2025

Binary Size Report

use_config/nrf52832_ble

   text	   data	    bss	    dec	    hex	filename
 294916	   5040	  34076	 334032	  518d0	rmk-nrf52832
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.5% +9.14Ki  [ = ]       0    .debug_str
  +0.6% +8.63Ki  [ = ]       0    .debug_info
  +0.8% +1.83Ki  [ = ]       0    .strtab
  +0.7% +1.71Ki  +0.7% +1.71Ki    .text
  +0.5% +1.14Ki  [ = ]       0    .debug_line
  +0.2% +1.02Ki  [ = ]       0    .debug_loc
  +0.6%    +920  [ = ]       0    .debug_ranges
  +0.6%    +544  [ = ]       0    .symtab
  [ = ]       0  +0.9%    +288    .bss
  +0.8%    +240  [ = ]       0    .debug_frame
  +0.3%     +96  [ = ]       0    .debug_aranges
  +5.4%      +3  [ = ]       0    [Unmapped]
  +0.2%      +1  [ = ]       0    .defmt
  -0.3%     -22  [ = ]       0    .debug_abbrev
  -0.4%    -128  -0.4%    -128    .rodata
  +0.5% +25.1Ki  +0.6% +1.87Ki    TOTAL

use_config/nrf52840_ble

   text	   data	    bss	    dec	    hex	filename
 322068	   5040	  52260	 379368	  5c9e8	rmk-nrf52840
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +9.89Ki  [ = ]       0    .debug_str
  +0.6% +9.09Ki  [ = ]       0    .debug_info
  +0.7% +1.80Ki  [ = ]       0    .strtab
  +0.6% +1.73Ki  +0.6% +1.73Ki    .text
  +0.5% +1.34Ki  [ = ]       0    .debug_line
  +0.2% +1.12Ki  [ = ]       0    .debug_loc
  +0.5%    +896  [ = ]       0    .debug_ranges
  +0.5%    +512  [ = ]       0    .symtab
  +0.6%    +208  [ = ]       0    .debug_frame
  +0.2%     +80  [ = ]       0    .debug_aranges
  +0.3%     +21  [ = ]       0    .debug_abbrev
  +0.1%      +1  [ = ]       0    .defmt
 -11.8%      -6  [ = ]       0    [Unmapped]
  -0.3%    -128  -0.3%    -128    .rodata
  +0.5% +26.5Ki  +0.4% +1.60Ki    TOTAL

use_config/nrf52840_ble_split

   text	   data	    bss	    dec	    hex	filename
 394740	   6260	  38828	 439828	  6b614	central

   text	   data	    bss	    dec	    hex	filename
 260496	   5668	  25460	 291624	  47328	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +9.97Ki  [ = ]       0    .debug_str
  +0.5% +8.91Ki  [ = ]       0    .debug_info
  +0.4% +2.11Ki  [ = ]       0    .debug_loc
  +0.5% +1.82Ki  +0.5% +1.82Ki    .text
  +0.6% +1.59Ki  [ = ]       0    .strtab
  +0.5% +1.29Ki  [ = ]       0    .debug_line
  +0.4%    +704  [ = ]       0    .debug_ranges
  [ = ]       0  +1.2%    +432    .bss
  +0.2%    +256  [ = ]       0    .symtab
  +0.2%     +80  [ = ]       0    .debug_frame
   +64%     +28  [ = ]       0    [Unmapped]
  +0.3%     +22  [ = ]       0    .debug_abbrev
  +0.0%     +16  [ = ]       0    .debug_aranges
  -0.4%    -160  -0.4%    -160    .rodata
  +0.4% +26.6Ki  +0.5% +2.08Ki    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.1%    +854  [ = ]       0    .debug_str
   +29%     +14  [ = ]       0    [Unmapped]
  +0.0%      +8  [ = ]       0    .debug_aranges
  +0.0%      +2  [ = ]       0    .strtab
  -0.0%      -4  -0.0%      -4    .text
  -0.0%    -108  [ = ]       0    .debug_info
  -0.1%    -114  [ = ]       0    .debug_line
  -0.8%    -228  -0.8%    -228    .rodata
  +0.0%    +424  -0.1%    -232    TOTAL

use_config/pi_pico_w_ble

   text	   data	    bss	    dec	    hex	filename
 560784	      0	  53132	 613916	  95e1c	rmk-pi-pico-w
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.5% +11.1Ki  [ = ]       0    .debug_str
  +0.5% +9.42Ki  [ = ]       0    .debug_info
  +0.3% +2.38Ki  [ = ]       0    .debug_loc
  +0.8% +2.12Ki  +0.8% +2.12Ki    .text
  +0.8% +1.77Ki  [ = ]       0    .strtab
  +0.6% +1.74Ki  [ = ]       0    .debug_line
  +1.0% +1.72Ki  [ = ]       0    .debug_ranges
  +0.6%    +368  [ = ]       0    .symtab
  [ = ]       0  +0.3%    +144    .bss
  +0.5%    +144  [ = ]       0    .debug_frame
  +0.2%     +48  [ = ]       0    .debug_aranges
   +45%     +19  [ = ]       0    [Unmapped]
  +0.2%      +1  [ = ]       0    .defmt
  -0.2%     -22  [ = ]       0    .debug_abbrev
  -0.1%    -144  -0.1%    -144    .rodata
  +0.5% +30.6Ki  +0.4% +2.12Ki    TOTAL

use_config/pi_pico_w_ble_split

   text	   data	    bss	    dec	    hex	filename
 589228	      0	  55716	 644944	  9d750	central

   text	   data	    bss	    dec	    hex	filename
 477192	      0	  41728	 518920	  7eb08	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.4% +11.6Ki  [ = ]       0    .debug_str
  +0.6% +10.6Ki  [ = ]       0    .debug_info
  +0.4% +3.41Ki  [ = ]       0    .debug_loc
  +0.8% +2.25Ki  +0.8% +2.25Ki    .text
  +0.7% +1.77Ki  [ = ]       0    .strtab
  +0.5% +1.66Ki  [ = ]       0    .debug_line
  +0.6% +1.05Ki  [ = ]       0    .debug_ranges
  +0.6%    +416  [ = ]       0    .symtab
  [ = ]       0  +0.4%    +216    .bss
  +0.4%    +144  [ = ]       0    .debug_frame
  +0.2%     +48  [ = ]       0    .debug_aranges
  +0.1%      +1  [ = ]       0    .defmt
 -30.0%     -15  [ = ]       0    [Unmapped]
  -0.1%    -176  -0.1%    -176    .rodata
  +0.5% +32.7Ki  +0.4% +2.29Ki    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  [ = ]       0    .debug_aranges
  +0.0%      +3  [ = ]       0    .strtab
  -0.0%      -4  -0.0%      -4    .text
 -35.9%     -23  [ = ]       0    [Unmapped]
  -0.0%     -97  [ = ]       0    .debug_info
  -0.0%    -117  [ = ]       0    .debug_line
  -0.1%    -228  -0.1%    -228    .rodata
  -0.0%    -462  [ = ]       0    .debug_str
  -0.0%    -920  -0.0%    -232    TOTAL

use_config/rp2040

   text	   data	    bss	    dec	    hex	filename
 117036	      0	  11452	 128488	  1f5e8	rmk-rp2040
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +8  [ = ]       0    .debug_str
  +0.0%      +5  [ = ]       0    .debug_line
  +8.6%      +3  [ = ]       0    [Unmapped]
  +0.0%      +2  [ = ]       0    .debug_info
  -0.0%      -2  [ = ]       0    .strtab
  +0.0%     +16  [ = ]       0    TOTAL

use_config/rp2040_split

   text	   data	    bss	    dec	    hex	filename
 131892	      0	  12292	 144184	  23338	central

   text	   data	    bss	    dec	    hex	filename
  22432	      0	   2224	  24656	   6050	peripheral
Diff

Central Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +4  [ = ]       0    .debug_line
  +0.0%      +2  [ = ]       0    .debug_info
  -1.7%      -1  [ = ]       0    [Unmapped]
  -0.0%      -5  [ = ]       0    .debug_str
  -0.0%      -8  [ = ]       0    .strtab
  -0.0%      -8  [ = ]       0    TOTAL

Peripheral Diff

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +3  [ = ]       0    .strtab
  +0.0%      +1  [ = ]       0    .debug_info
  +2.0%      +1  [ = ]       0    [Unmapped]
  -0.0%      -5  [ = ]       0    .debug_str
  [ = ]       0  [ = ]       0    TOTAL

use_config/stm32f1

   text	   data	    bss	    dec	    hex	filename
  74276	     24	   9392	  83692	  146ec	rmk-stm32f1
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +19  [ = ]       0    .debug_line
  +0.0%      +8  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    .debug_str
  +0.0%      +2  [ = ]       0    .debug_info
  -9.1%      -5  [ = ]       0    [Unmapped]
  +0.0%     +28  [ = ]       0    TOTAL

use_config/stm32f4

   text	   data	    bss	    dec	    hex	filename
 119612	    316	  12088	 132016	  203b0	rmk-stm32f4
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%      +9  [ = ]       0    .debug_line
  +0.0%      +2  [ = ]       0    .debug_info
  +0.0%      +1  [ = ]       0    .debug_str
  -5.1%      -3  [ = ]       0    [Unmapped]
  -0.0%      -5  [ = ]       0    .strtab
  +0.0%      +4  [ = ]       0    TOTAL

use_config/stm32h7

   text	   data	    bss	    dec	    hex	filename
 126512	    316	  12444	 139272	  22008	rmk-stm32h7
Diff
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%     +12  [ = ]       0    .debug_line
  +0.0%     +12  [ = ]       0    .strtab
  +0.0%      +3  [ = ]       0    .debug_str
  +0.0%      +2  [ = ]       0    .debug_info
  -1.4%      -1  [ = ]       0    [Unmapped]
  +0.0%     +28  [ = ]       0    TOTAL

Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu force-pushed the feat/conn_update branch from 45fcf69 to b55bcac Compare July 1, 2025 02:30
Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu force-pushed the feat/conn_update branch from b55bcac to 5146107 Compare July 1, 2025 02:55
HaoboGu added 3 commits July 1, 2025 11:03
Signed-off-by: Haobo Gu <haobogu@outlook.com>
Signed-off-by: Haobo Gu <haobogu@outlook.com>
Signed-off-by: Haobo Gu <haobogu@outlook.com>
Copy link

Deploying rmk with  Cloudflare Pages  Cloudflare Pages

Latest commit: bb112e6
Status: ✅  Deploy successful!
Preview URL: https://f50eaf81.rmk-4a2.pages.dev
Branch Preview URL: https://feat-conn-update.rmk-4a2.pages.dev

View logs

Signed-off-by: Haobo Gu <haobogu@outlook.com>
@HaoboGu HaoboGu marked this pull request as ready for review July 1, 2025 03:24
@HaoboGu HaoboGu merged commit 74c1b6c into main Jul 1, 2025
43 checks passed
@HaoboGu HaoboGu deleted the feat/conn_update branch July 4, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant