Sync Strings #4804
Sync Strings #4804
Conversation
ElementBot
commented
Jun 2, 2025
ElementBot
commented
- Update Strings from Localazy
github-actions
bot
added
the
Z-Community-PR
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4804 +/- ##
========================================
Coverage 80.43% 80.43%
========================================
Files 2143 2143
Lines 56769 56769
Branches 7120 7120
========================================
Hits 45660 45660
Misses 8672 8672
Partials 2437 2437 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| <string name="screen_create_room_room_access_section_anyone_option_description">"Jeder kann diesem Chatroom beitreten"</string> | ||
| <string name="screen_create_room_room_access_section_anyone_option_title">"Jemand"</string> | ||
| <string name="screen_create_room_room_access_section_header">"Chatroom Zugang"</string> | ||
| <string name="screen_create_room_room_access_section_knocking_option_description">"Jeder kann darum bitten, dem Chatroom beizutreten, aber ein Administrator oder ein Moderator muss die Anfrage akzeptieren."</string> |
There was a problem hiding this comment.
It's weird that they removed the 'or administrator' part here.
There was a problem hiding this comment.
Hi, that would probably be me, I cleaned up more than a 100 strings, making the wording more consistent (use the same terms).
This specific change is probably a debatable change, but admin>moderator, so "a moderator" implies someone more important than a aregular member. German is such a long languages that many dialogs were overflowing or cutoff, so taking some shortcuts seemed acceptable.
On the plus side, some external reviewer seems to have OK'd my proposal :-)
There was a problem hiding this comment.
There are some changes in strings, but these were approved by us in Localazy, so we should probably use them as they are. @bmarty do you agree?
|
Yes, that's fine to me. |
