Skip to content

Add the tree-widget example to the generator #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 28, 2025

Conversation

xpomul
Copy link
Contributor

@xpomul xpomul commented Mar 13, 2025

What it does

Add an example demonstrating how to implement a custom TreeWidget including several of its features.

Follow-ups

This example is referred in a new documentation page on the Theia website (see this PR: eclipse-theia/theia-website#736).

Notes

This is a followup to eclipse-theia/theia#15127 where I initially added the example to theia/examples.
This PR replaces that one by adding the example to the generator instead.

Signed-Off-By: Stefan Winkler <stefan@winklerweb.net>
@xpomul
Copy link
Contributor Author

xpomul commented Mar 15, 2025

Note: the Build failure is caused by eclipse-theia/theia#15139

@JonasHelming
Copy link
Contributor

@xpomul How di you work around the build failure locally?

@xpomul
Copy link
Contributor Author

xpomul commented Mar 21, 2025

@xpomul How di you work around the build failure locally?

basically I ignore the yarn failure at the end of the yo execution and build/test using
npm install && npm run build:browser && npm run start:browser

for some reason, building with npm works for me…

@JonasHelming
Copy link
Contributor

Could it be that you switched to an NPM version higher than 2.14?

@JonasHelming
Copy link
Contributor

Thank you for the contribution btw! I will have a look at this once eclipse-theia/theia#15139 is solved

Copy link

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for contribution an example for a tree widget! Especially with the createTreeContainer usage might not be straightforward for everyone and this will help for sure. I do have some comments though, please have a look.

xpomul and others added 2 commits April 23, 2025 15:14
Co-authored-by: Martin Fleck <mfleck@eclipsesource.com>
Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
@xpomul xpomul requested a review from martin-fleck-at April 23, 2025 13:29
@martin-fleck-at
Copy link

Besides the checkbox issue, everything looks good to me now, thank you for the quick update!

which prevents proper reflection of checkbox state changes in the UI

Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
Copy link

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @xpomul! Everything looks good to me now!

@martin-fleck-at martin-fleck-at merged commit d818971 into eclipse-theia:master Apr 28, 2025
4 checks passed
@JonasHelming
Copy link
Contributor

I created a release containing this PR! https://github.com/eclipse-theia/generator-theia-extension/releases/tag/v0.1.43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants