-
Notifications
You must be signed in to change notification settings - Fork 44
Add the tree-widget example to the generator #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-Off-By: Stefan Winkler <stefan@winklerweb.net>
Note: the Build failure is caused by eclipse-theia/theia#15139 |
@xpomul How di you work around the build failure locally? |
basically I ignore the yarn failure at the end of the yo execution and build/test using for some reason, building with npm works for me… |
Could it be that you switched to an NPM version higher than 2.14? |
Thank you for the contribution btw! I will have a look at this once eclipse-theia/theia#15139 is solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for contribution an example for a tree widget! Especially with the createTreeContainer
usage might not be straightforward for everyone and this will help for sure. I do have some comments though, please have a look.
Co-authored-by: Martin Fleck <mfleck@eclipsesource.com> Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
Besides the checkbox issue, everything looks good to me now, thank you for the quick update! |
which prevents proper reflection of checkbox state changes in the UI Signed-off-by: Stefan Winkler <stefan@winklerweb.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @xpomul! Everything looks good to me now!
I created a release containing this PR! https://github.com/eclipse-theia/generator-theia-extension/releases/tag/v0.1.43 |
What it does
Add an example demonstrating how to implement a custom TreeWidget including several of its features.
Follow-ups
This example is referred in a new documentation page on the Theia website (see this PR: eclipse-theia/theia-website#736).
Notes
This is a followup to eclipse-theia/theia#15127 where I initially added the example to
theia/examples
.This PR replaces that one by adding the example to the generator instead.