Skip to content

Update to Theia 1.60 (Lumino) #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #15216
sdirix opened this issue Mar 18, 2025 · 4 comments
Closed
Tracked by #15216

Update to Theia 1.60 (Lumino) #242

sdirix opened this issue Mar 18, 2025 · 4 comments
Assignees

Comments

@sdirix
Copy link
Member

sdirix commented Mar 18, 2025

Theia 1.60 will contain the migration from PhosphorJS to Lumino. We need to test all examples whether they continue to work as is.

Known breakage:

  • The tree-editor consumes a version of @eclipse-emfcloud/theia-tree-editor which will not work without adaption, see here.
@JonasHelming
Copy link
Contributor

@sdirix I would be in favor of just removing and deprecating the example then, WDYT? there is a new example upcoming as well: #241

@JonasHelming
Copy link
Contributor

@sdirix Is there a migration guide on how to find "for sure" breakages?

@sdirix
Copy link
Member Author

sdirix commented Mar 18, 2025

@sdirix I would be in favor of just removing and deprecating the example then, WDYT? there is a new example upcoming as well: #241

Depends on whether there will be an adopted version of the tree editor. It's likely a low effort change for them.

@sdirix Is there a migration guide on how to find "for sure" breakages?

There is no specific guide.

For sure breakages are:

  • All imports of @theia/core/shared/@phosphor will break
  • All custom CSS referring to phosphor classes, e.g. .p-TabBar, needs to be changed, e.g. to .lm-TabBar.

95% breakages are:

  • Non-shared imports of @phosphor will very likely lead to typing issues in the best case and runtime errors in the worst case. They should be adapted too

Potential breakages which can not be found without testing:

  • Slight behavior changes of Phosphor vs Lumino which have an effect on adopter code base, e.g. empty menu handling
  • Code we adopted in Theia and downstream adopters with deep customizations need to adapt too, for example a new initialize promise of the shell to wait for.

For the generator extensions I don't think we will have issues besides the tree-editor, but let's see.

@JonasHelming
Copy link
Contributor

Tested the new release, works with Lumino: https://github.com/eclipse-theia/generator-theia-extension/releases/tag/v0.1.42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants