-
Notifications
You must be signed in to change notification settings - Fork 295
Fix LLVM easyblock to allow building with multiple versions at once #3812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
158174d
to
65b7fb3
Compare
65b7fb3
to
2961940
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (1 easyconfigs in total) |
Test report by @boegel Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
also tested extensively via easybuilders/easybuild-easyconfigs#23033
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 3 (3 easyconfigs in total) |
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 3 (3 easyconfigs in total) |
Test report by @boegelbot Overview of tested easyconfigs (in order)
Build succeeded for 2 out of 2 (2 easyconfigs in total) |
Test report by @Flamefire Overview of tested easyconfigs (in order)
Build succeeded for 3 out of 3 (3 easyconfigs in total) |
This ensures that the global dicts used as default values are not modified anymore and hence a following build gets a fresh copy.
This avoids failures when building different LLVM versions with conflicting settings.
I also pulled out 2 changes from #3755
usepolly
touse_polly
Can be tested with easybuilders/easybuild-easyconfigs#23033 which renames the uses of
usepolly
in easyconfigs and hence also serves as a test case for the fixThe resulting installations should be identical to the ones before
Fixes #3758