-
Notifications
You must be signed in to change notification settings - Fork 295
New EasyBlock for ROCm-LLVM #3823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Thyre
wants to merge
4
commits into
easybuilders:develop
Choose a base branch
from
Thyre:20250703202924_new_pr_rocm_llvm
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+133
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
42a7da6
to
51e9ad9
Compare
4 tasks
Zeldhoron
suggested changes
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During testing this, when I was trying to build ROCm-LLVM, I added some small changes that fixed some issues for me.
Zeldhoron
reviewed
Jul 17, 2025
Co-Authored-By: Bob Dröge <b.e.droge@rug.nl>
Co-authored-by: Zeldhoron <Zeldhoron@users.noreply.github.com>
Co-authored-by: Zeldhoron <Zeldhoron@users.noreply.github.com>
111d016
to
51dfd8b
Compare
51dfd8b
to
643e705
Compare
Signed-off-by: Jan André Reuter <j.reuter@fz-juelich.de>
643e705
to
8e3ca37
Compare
First test report: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr
)Requires:
cuda-compute-capabilities
easybuild-framework#4860TODO:
LIBOMPTARGET_AMDGCN_GFXLIST
This PR introduces a separate EasyBlock for ROCm-LLVM, based on the heavy lifting of the LLVM EasyBlock. A few options need to be set differently, e.g. explicit disabling of #3747 due to the "generic" ROCm-LLVM interface not being compatible with the actual HSA being used in their OpenMP Tools Interface.
Lots of work has been done by @bedroge to get this EasyBlock working at all, thanks for that!