fix: fallback to user prefered mode instead of assuming dark mode for first-time theme load #651
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug:
clear the cookie and load the website on a system that has light theme preferred
Expected:
you should get light mode
Actual:
you get dark mode
Fix:
when loading the theme from cookie, if no theme is found, try detecting user-prefered theme, and then fallback to dark mode
NOTE
also changed the code a bit, to allow for non-binary options, like having a thrid
auto-detect
option, or other theme names