Skip to content

fix: allow theme state to be persisted #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025
Merged

Conversation

AliAkrem
Copy link
Contributor

@AliAkrem AliAkrem commented Apr 8, 2025

changes

  • store theme state in local storage
  • apply theme changes directly into the "data-theme" attribute

preview

Screencast.from.2025-04-08.15-25-34.webm

note: I set the default theme to be dark feel free to change it

  • Bug fix
  • New feature
  • Other

fix: #616

@github-actions github-actions bot added the web Web related changes ( web folder ) label Apr 8, 2025
@omdxp omdxp self-requested a review April 9, 2025 09:44
Copy link
Member

@omdxp omdxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-project-automation github-project-automation bot moved this to Approved in DzCode i/o Apr 9, 2025
@omdxp omdxp merged commit 1813fa4 into dzcode-io:main Apr 9, 2025
35 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Merged in DzCode i/o Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix web Web related changes ( web folder )
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

The user's light/dark mode preference is not persisted
3 participants