Skip to content

fix: allow theme state to be persisted #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 9, 2025
Merged

fix: allow theme state to be persisted #645

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ecff04b
feat: integrate theme-change library for theme toggling
AliAkrem Apr 8, 2025
a17dc05
refactor: memoize toggleTheme function
AliAkrem Apr 8, 2025
ea6db24
chore: format code
AliAkrem Apr 8, 2025
b7c36ee
refactor: remove unused package theme-change
AliAkrem Apr 8, 2025
4f8a59a
fix: update dependencies in toggleTheme
AliAkrem Apr 8, 2025
24e0180
Merge branch 'main' into main
AliAkrem Apr 8, 2025
d797ff5
Update web/src/components/top-bar.tsx
omdxp Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions web/src/components/top-bar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from "react";
import { useMemo, useLayoutEffect, useState } from "react";
import { useMemo, useLayoutEffect, useState, useCallback } from "react";
import { useLocation } from "react-router-dom";
import logoWide from "src/assets/svg/logo-wide.svg";
import logoSquare from "src/assets/svg/logo-square.svg";
Expand Down Expand Up @@ -55,12 +55,12 @@ export function TopBar({ version, links }: TopBarProps): JSX.Element {
}
}, []);

function toggleTheme() {
const toggleTheme = useCallback(() => {
const newTheme = isDark ? "light" : "dark";
setIsDark(!isDark);
localStorage.setItem("theme", newTheme);
document.documentElement.setAttribute("data-theme", newTheme);
}
}, [isDark]);

return (
<div className="bg-neutral">
Expand Down Expand Up @@ -134,7 +134,9 @@ export function TopBar({ version, links }: TopBarProps): JSX.Element {
<path d="M21 12.79A9 9 0 1 1 11.21 3 7 7 0 0 0 21 12.79z"></path>
</svg>
<input
onClick={toggleTheme}
onClick={() => {
toggleTheme();
}}
id="theme-toggle"
type="checkbox"
value="dzcodeLight"
Expand Down
Loading