Global review of the project (part 1) #600
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreaTP
force-pushed
the
api-review-part1
branch
from
03e6cd4 to
e4bfd77
Compare
evacchi
approved these changes
Oct 23, 2024
| INSTANCE_CALL_HOST_FUNCTION = | ||
| Instance.class.getMethod("callHostFunction", int.class, long[].class); | ||
| INSTANCE_READ_GLOBAL = Instance.class.getMethod("readGlobal", int.class); | ||
| READ_GLOBAL = AotMethods.class.getMethod("readGlobal", int.class, Instance.class); |
There was a problem hiding this comment.
I'd say this and related are the most notable changes in the PR. The rest of it is changes to the visibility of some class and methods so that they are all package-private
Comment on lines
-269
to
-285
| return globals[idx - importedGlobalsOffset]; | ||
| } | ||
|
|
||
| public void writeGlobal(int idx, long val) { | ||
| if (idx < importedGlobalsOffset) { | ||
| imports.global(idx).instance().setValue(val); | ||
| } | ||
| globals[idx - importedGlobalsOffset].setValue(val); | ||
| } | ||
|
|
||
| public ValueType readGlobalType(int idx) { | ||
| if (idx < importedGlobalsOffset) { | ||
| return imports.global(idx).instance().getType(); | ||
| } | ||
| return globals[idx - importedGlobalsOffset].getType(); | ||
| } | ||
|
|
||
| public long readGlobal(int idx) { | ||
| if (idx < importedGlobalsOffset) { | ||
| return imports.global(idx).instance().getValue(); | ||
| } |
There was a problem hiding this comment.
the "related" change I was mention in the other comment.
|
As promised, I have created a bunch of issues for about half the notes in the gist. The others I think can be considered minor and/or already in progress, but feel free to create more. I have also assigned a few to myself, but
|
Co-authored-by: evacchi <evacchi@users.noreply.github.com>
andreaTP
force-pushed
the
api-review-part1
branch
from
e4bfd77 to
ab965d5
Compare
bhelx
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks a ton to @evacchi that paired on this time-consuming task ❤️
We did an almost full (file by file) review of the project and actioned anything trivial, this is the list of remaining task/future ideas:
https://gist.github.com/andreaTP/da9ceaaa20b72d84fb07cc0d1471891c