Skip to content

Global review of the project (part 2) #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Global review of the project (part 2) #612

merged 1 commit into from
Oct 25, 2024

Conversation

@evacchi
Copy link
Collaborator

@evacchi evacchi commented Oct 25, 2024

follow up to #600.

  • Rename Limits to TableLimits for consistency with MemoryLimits
  • Rename Memory#memoryLimits() to Memory#limits() for consistency with Table#limits()
  • Delete unused ValueType#hasSize() essentially dual of ValueType#isReference()

@evacchi evacchi requested a review from andreaTP October 25, 2024 15:55
andreaTP
andreaTP approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andreaTP andreaTP merged commit c369d28 into dylibso:main Oct 25, 2024
13 checks passed
@evacchi evacchi deleted the review-part-2 branch October 25, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreaTP andreaTP andreaTP approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@evacchi @andreaTP