[browser] Expect fingerprint on dotnet.js for preloading #120694
Draft
+47
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraf
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
maraf
force-pushed
the
BrowserPreloadFingerprintIdentity
branch
from
d165553 to
60b7af6
Compare
|
/backport to release/10.0 |
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18528336397 |
4 tasks
|
This requires an SDK for WBT with dotnet/sdk#51274 |
maraf
added
the
NO-MERGE
This was referenced Oct 17, 2025
Open
lewing
added a commit
that referenced
this pull request
Oct 17, 2025
…ng (#120746) Backport of #120694 to release/10.0 In dotnet/sdk#50949 we changed the identity of StaticWebAsset to contain fingerprint (dotnet.native.wasm -> dotnet.native.FP.wasm). This PR accommodates this when checking for dotnet.native.wasm asset from build. The SDK change didn't flown to the runtime yet, and so Wasm.Build.Tests won't test it yet. Fixes dotnet/aspnetcore#64011 /cc @maraf ## Customer Impact - [ ] Customer reported - [x] Found internally [[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]](dotnet/aspnetcore#64011) ## Regression - [x] Yes - [ ] No Introduced in dotnet/sdk#50949 which added a fingerprint to the msbuild item identity ## Testing Manual and automated tests. ## Risk Low. The change are very scoped to target and items used only by preloading. **IMPORTANT**: If this backport is for a servicing release, please verify that: - The PR target branch is `release/X.0-staging`, not `release/X.0`. ## Package authoring no longer needed in .NET 9 **IMPORTANT**: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version. Keep in mind that we still need package authoring in .NET 8 and older versions. --------- Co-authored-by: Marek Fišera <mara@neptuo.com> Co-authored-by: Larry Ewing <lewing@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect fingerprint in SWA identity when searching for
dotnet.jsto apply preloading properties to.The change is build-time only, we don't need to update the target for publish, because the
publish.dotnet.jsdoesn't get fingerprint in the identity.Contributes to dotnet/aspnetcore#64011