-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/10.0] [browser] Expect fingerprint on dotnet.js for preloading #120746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release/10.0
Are you sure you want to change the base?
Conversation
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Use newer SDK for WBT
Preloading tests have passed https://helix.dot.net/api/jobs/0b9661f4-51e1-4aca-823d-589e6a0c02b1/workitems/NoWebcil-ST-Wasm.Build.Tests.PreloadingTests?api-version=2019-06-17 The other failures are caused by missing changes from #120743 |
/ba-g All linux Wasm.Build.Tests passed. Other failures are unrelated. |
Backport of #120694 to release/10.0
In dotnet/sdk#50949 we changed the identity of StaticWebAsset to contain fingerprint (dotnet.native.wasm -> dotnet.native.FP.wasm). This PR accommodates this when checking for dotnet.native.wasm asset from build.
The SDK change didn't flown to the runtime yet, and so Wasm.Build.Tests won't test it yet.
Fixes dotnet/aspnetcore#64011
/cc @maraf
Customer Impact
[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]
Regression
Introduced in dotnet/sdk#50949 which added a fingerprint to the msbuild item identity
Testing
Manual and automated tests.
Risk
Low. The change are very scoped to target and items used only by preloading.
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging
, notrelease/X.0
.Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.