-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove InternalsVisibleTo for Toolkit #28994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuarezruiz
previously approved these changes
Apr 16, 2025
/rebase |
rmarinho
previously approved these changes
Apr 21, 2025
cf9b02c
to
d5fc0e3
Compare
Built the .NET MAUI Community Toolkit against this version and seems like these are the APIs that are currently used, but are internal to .NET MAUI:
From what I can determine the above ones are used in Popup, but will be removed with the new Popups implementation that is in a PR right now. For the rest:
|
d5fc0e3
to
5387b70
Compare
🚨 API change(s) detected @davidbritch FYI |
rmarinho
approved these changes
Apr 25, 2025
jfversluis
added a commit
that referenced
this pull request
May 5, 2025
This reverts commit 504aa86.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Removes the
InternalsVisibleTo
for the .NET MAUI Community Toolkit. We shouldn't need that, it was done for historic reasons, but to prevent further unintentional breaking changes like #28450 we should remove it.This PR:
InternalsVisibleTo
attribute from all the .NET MAUI projects in regard to the ToolkitIssues Fixed
Fixes #28981