Update AppThemeResourceExtension to not use IProvideParentValues #2639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
added
the
area/extensions
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the AppThemeResourceExtension to remove the dependency on IProvideParentValues and instead use IProvideValueTarget and IRootObjectProvider for resource lookup. Key changes include:
- Updating the RequiredService attribute to target IProvideValueTarget and IRootObjectProvider.
- Replacing the old resource lookup via parent objects with a new strategy that walks the visual tree and falls back to the root object's resources and Application.Current resources.
- Streamlining error messages and exception handling for cases where resources are missing or invalid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR updates
AppThemeResourceExtensionto not useIProvideParentValues, which is internal to .NET MAUI.At the .NET MAUI side we're exploring to remove the InternalsVisibleTo for the Toolkit since it shouldn't be necessary.
Most APIs there will be removed with the Popup v2 implementation (yay), the rest are being used in AvatarView and we're OK to make those public on the .NET MAUI side for .NET 10, but the one used in
AppThemeResourceExtensionwe're not OK with making public.Therefore, this PR explores an alternative implementation that does not use
IProvideParentValues