Use char overloads to Join/Index strings #56531
Conversation
martincostello
requested review from
a team,
javiercn,
BrennanConroy,
halter73 and
captainsafia
as code owners
ghost
added
the
area-networking
dotnet-policy-service
bot
added
the
community-contribution
dotnet-policy-service
bot
added
the
pending-ci-rerun
martincostello
removed
the
pending-ci-rerun
Use overloads that take a `char` for single-character strings.
martincostello
force-pushed
the
use-char-overloads
branch
from
e46a36f to
ea196a1
Compare
|
CI failure looks unrelated - that analyzer has been failing in a lot of runs. Edit: Oh fancy, we have a bot to tag known failures now? |
| @@ -179,17 +179,17 @@ public static BindingAddress Parse(string address) | |||
| } | |||
| } | |||
|
|
|||
| pathDelimiterStart = address.IndexOf(":", schemeDelimiterEnd + unixPipeHostPrefixLength, StringComparison.Ordinal); | |||
There was a problem hiding this comment.
Not your fault, but it seems very weird that the char version doesn't (AFAICT) accept a StringComparison. I'm assuming the default is Ordinal?
There was a problem hiding this comment.
I'll double-check this one locally in an IDE.
There was a problem hiding this comment.
I couldn't find one a char, int, StringComparison overload.
The IDE code-fixer also suggests exactly what's here:
I'm gonna guess that it does an ordinal check anyway and in this case as it's punctuation it's moot.
There was a problem hiding this comment.
Sorry, I should have been clearer - there isn't a better overload you could have called. I don't know why that is, but you don't need to do anything about it.
I just confirmed in the source that the default comparison is Ordinal so the change looks correct (if, sadly, less explicit).
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Pull request was closed
Use char overloads to Join/Index strings
Use overloads that take a
charfor single-character strings.Description
Use overloads that take a
charfor single-character strings where relevant withstring.Join()or{Last}IndexOf()to resolve a number of analyser suggestions.Also fixes a few IDE0055 diagnostics.