Use char overloads (#56531)

martincostello · web-flow · commit dfc5189cb5b9 · 2024-07-19T16:45:38.000Z
Use overloads that take a `char` for single-character strings.
diff --git a/src/Hosting/TestHost/src/ClientHandler.cs b/src/Hosting/TestHost/src/ClientHandler.cs
@@ -159,7 +159,7 @@ protected override async Task<HttpResponseMessage> SendAsync(
                 // User-Agent is a space delineated single line header but HttpRequestHeaders parses it as multiple elements.
                 if (string.Equals(header.Key, HeaderNames.UserAgent, StringComparison.OrdinalIgnoreCase))
                 {
-                    req.Headers.Append(header.Key, string.Join(" ", header.Value));
+                    req.Headers.Append(header.Key, string.Join(' ', header.Value));
                 }
                 else
                 {
diff --git a/src/Http/Authentication.Abstractions/src/TokenExtensions.cs b/src/Http/Authentication.Abstractions/src/TokenExtensions.cs
@@ -46,7 +46,7 @@ public static void StoreTokens(this AuthenticationProperties properties, IEnumer
 
         if (tokenNames.Count > 0)
         {
-            properties.Items[TokenNamesKey] = string.Join(";", tokenNames);
+            properties.Items[TokenNamesKey] = string.Join(';', tokenNames);
         }
     }
 
diff --git a/src/Http/Http.Abstractions/src/Internal/ParsingHelpers.cs b/src/Http/Http.Abstractions/src/Internal/ParsingHelpers.cs
@@ -57,7 +57,7 @@ public static void SetHeaderJoined(IHeaderDictionary headers, string key, String
         }
         else
         {
-            headers[key] = string.Join(",", value.Select(QuoteIfNeeded));
+            headers[key] = string.Join(',', value.Select(QuoteIfNeeded));
         }
     }
 
@@ -116,7 +116,7 @@ public static void AppendHeaderJoined(IHeaderDictionary headers, string key, par
         }
         else
         {
-            headers[key] = existing + "," + string.Join(",", values.Select(QuoteIfNeeded));
+            headers[key] = existing + "," + string.Join(',', values.Select(QuoteIfNeeded));
         }
     }
 
diff --git a/src/Http/Http.Abstractions/src/WebSocketManager.cs b/src/Http/Http.Abstractions/src/WebSocketManager.cs
@@ -51,7 +51,7 @@ private string DebuggerToString()
         return IsWebSocketRequest switch
         {
             false => "IsWebSocketRequest = false",
-            true => $"IsWebSocketRequest = true, RequestedProtocols = {string.Join(",", WebSocketRequestedProtocols)}",
+            true => $"IsWebSocketRequest = true, RequestedProtocols = {string.Join(',', WebSocketRequestedProtocols)}",
         };
     }
 
diff --git a/src/Http/Http/src/BindingAddress.cs b/src/Http/Http/src/BindingAddress.cs
@@ -179,17 +179,17 @@ public static BindingAddress Parse(string address)
                 }
             }
 
-            pathDelimiterStart = address.IndexOf(":", schemeDelimiterEnd + unixPipeHostPrefixLength, StringComparison.Ordinal);
+            pathDelimiterStart = address.IndexOf(':', schemeDelimiterEnd + unixPipeHostPrefixLength);
             pathDelimiterEnd = pathDelimiterStart + ":".Length;
         }
         else if (isNamedPipe)
         {
-            pathDelimiterStart = address.IndexOf(":", schemeDelimiterEnd + NamedPipeHostPrefix.Length, StringComparison.Ordinal);
+            pathDelimiterStart = address.IndexOf(':', schemeDelimiterEnd + NamedPipeHostPrefix.Length);
             pathDelimiterEnd = pathDelimiterStart + ":".Length;
         }
         else
         {
-            pathDelimiterStart = address.IndexOf("/", schemeDelimiterEnd, StringComparison.Ordinal);
+            pathDelimiterStart = address.IndexOf('/', schemeDelimiterEnd);
             pathDelimiterEnd = pathDelimiterStart;
         }
 
@@ -205,7 +205,7 @@ public static BindingAddress Parse(string address)
         var hasSpecifiedPort = false;
         if (!isUnixPipe)
         {
-            var portDelimiterStart = address.LastIndexOf(":", pathDelimiterStart - 1, pathDelimiterStart - schemeDelimiterEnd, StringComparison.Ordinal);
+            var portDelimiterStart = address.LastIndexOf(':', pathDelimiterStart - 1, pathDelimiterStart - schemeDelimiterEnd);
             if (portDelimiterStart >= 0)
             {
                 var portDelimiterEnd = portDelimiterStart + ":".Length;
diff --git a/src/Http/Http/src/Features/FormFeature.cs b/src/Http/Http/src/Features/FormFeature.cs
@@ -72,19 +72,19 @@ private MediaTypeHeaderValue? ContentType
     {
         get
         {
-			MediaTypeHeaderValue? mt = null;
+            MediaTypeHeaderValue? mt = null;
 
-			if (_request is not null)
-			{
-				_ = MediaTypeHeaderValue.TryParse(_request.ContentType, out mt);
-			}
+            if (_request is not null)
+            {
+                _ = MediaTypeHeaderValue.TryParse(_request.ContentType, out mt);
+            }
 
-			if (_form is not null && mt is null)
-			{
-				mt = _formContentType;
-			}
+            if (_form is not null && mt is null)
+            {
+                mt = _formContentType;
+            }
 
-			return mt;
+            return mt;
         }
     }
 
@@ -127,9 +127,9 @@ public IFormCollection? Form
             {
                 _formContentType = null;
             }
-			else
+            else
             {
-				_formContentType ??= new MediaTypeHeaderValue("application/x-www-form-urlencoded");
+                _formContentType ??= new MediaTypeHeaderValue("application/x-www-form-urlencoded");
             }
         }
     }
diff --git a/src/Http/Routing/src/HostAttribute.cs b/src/Http/Routing/src/HostAttribute.cs
@@ -53,7 +53,7 @@ public override string ToString()
     {
         var hostsDisplay = (Hosts.Count == 0)
             ? "*:*"
-            : string.Join(",", Hosts.Select(h => h.Contains(':') ? h : h + ":*"));
+            : string.Join(',', Hosts.Select(h => h.Contains(':') ? h : h + ":*"));
 
         return DebuggerHelpers.GetDebugText(nameof(Hosts), hostsDisplay);
     }
diff --git a/src/Mvc/Mvc.Abstractions/src/ModelBinding/CompositeBindingSource.cs b/src/Mvc/Mvc.Abstractions/src/ModelBinding/CompositeBindingSource.cs
@@ -53,7 +53,7 @@ public static CompositeBindingSource Create(
             }
         }
 
-        var id = string.Join("&", bindingSources.Select(s => s.Id).OrderBy(s => s, StringComparer.Ordinal));
+        var id = string.Join('&', bindingSources.Select(s => s.Id).OrderBy(s => s, StringComparer.Ordinal));
         return new CompositeBindingSource(id, displayName, bindingSources);
     }
 
diff --git a/src/Security/Authorization/Policy/src/PolicyEvaluator.cs b/src/Security/Authorization/Policy/src/PolicyEvaluator.cs
@@ -54,7 +54,7 @@ public virtual async Task<AuthenticateResult> AuthenticateAsync(AuthorizationPol
             if (newPrincipal != null)
             {
                 context.User = newPrincipal;
-                var ticket = new AuthenticationTicket(newPrincipal, string.Join(";", policy.AuthenticationSchemes));
+                var ticket = new AuthenticationTicket(newPrincipal, string.Join(';', policy.AuthenticationSchemes));
                 // ExpiresUtc is the easiest property to reason about when dealing with multiple schemes
                 // SignalR will use this property to evaluate auth expiration for long running connections
                 ticket.Properties.ExpiresUtc = minExpiresUtc;
diff --git a/src/Shared/Diagnostics/BaseView.cs b/src/Shared/Diagnostics/BaseView.cs
@@ -118,7 +118,7 @@ protected void EndWriteAttribute()
         Debug.Assert(AttributeValues != null);
         Debug.Assert(!string.IsNullOrEmpty(AttributeEnding));
 
-        var attributes = string.Join(" ", AttributeValues);
+        var attributes = string.Join(' ', AttributeValues);
         Output.Write(attributes);
         AttributeValues = null;
 
diff --git a/src/Shared/RazorViews/BaseView.cs b/src/Shared/RazorViews/BaseView.cs
@@ -158,7 +158,7 @@ protected void EndWriteAttribute()
         Debug.Assert(AttributeValues != null);
         Debug.Assert(!string.IsNullOrEmpty(AttributeEnding));
 
-        var attributes = string.Join(" ", AttributeValues);
+        var attributes = string.Join(' ', AttributeValues);
         Output.Write(attributes);
         AttributeValues = null;
 

Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,7 @@ protected override async Task<HttpResponseMessage> SendAsync(`
`159`	`159`	`// User-Agent is a space delineated single line header but HttpRequestHeaders parses it as multiple elements.`
`160`	`160`	`if (string.Equals(header.Key, HeaderNames.UserAgent, StringComparison.OrdinalIgnoreCase))`
`161`	`161`	`{`
`162`		`- req.Headers.Append(header.Key, string.Join(" ", header.Value));`
	`162`	`+ req.Headers.Append(header.Key, string.Join(' ', header.Value));`
`163`	`163`	`}`
`164`	`164`	`else`
`165`	`165`	`{`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,7 @@ public static void StoreTokens(this AuthenticationProperties properties, IEnumer`
`46`	`46`
`47`	`47`	`if (tokenNames.Count > 0)`
`48`	`48`	`{`
`49`		`- properties.Items[TokenNamesKey] = string.Join(";", tokenNames);`
	`49`	`+ properties.Items[TokenNamesKey] = string.Join(';', tokenNames);`
`50`	`50`	`}`
`51`	`51`	`}`
`52`	`52`
Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ public static void SetHeaderJoined(IHeaderDictionary headers, string key, String`
`57`	`57`	`}`
`58`	`58`	`else`
`59`	`59`	`{`
`60`		`- headers[key] = string.Join(",", value.Select(QuoteIfNeeded));`
	`60`	`+ headers[key] = string.Join(',', value.Select(QuoteIfNeeded));`
`61`	`61`	`}`
`62`	`62`	`}`
`63`	`63`
`@@ -116,7 +116,7 @@ public static void AppendHeaderJoined(IHeaderDictionary headers, string key, par`
`116`	`116`	`}`
`117`	`117`	`else`
`118`	`118`	`{`
`119`		`- headers[key] = existing + "," + string.Join(",", values.Select(QuoteIfNeeded));`
	`119`	`+ headers[key] = existing + "," + string.Join(',', values.Select(QuoteIfNeeded));`
`120`	`120`	`}`
`121`	`121`	`}`
`122`	`122`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ private string DebuggerToString()`
`51`	`51`	`return IsWebSocketRequest switch`
`52`	`52`	`{`
`53`	`53`	`false => "IsWebSocketRequest = false",`
`54`		`- true => $"IsWebSocketRequest = true, RequestedProtocols = {string.Join(",", WebSocketRequestedProtocols)}",`
	`54`	`+ true => $"IsWebSocketRequest = true, RequestedProtocols = {string.Join(',', WebSocketRequestedProtocols)}",`
`55`	`55`	`};`
`56`	`56`	`}`
`57`	`57`
Original file line number	Diff line number	Diff line change
`@@ -179,17 +179,17 @@ public static BindingAddress Parse(string address)`
`179`	`179`	`}`
`180`	`180`	`}`
`181`	`181`
`182`		`- pathDelimiterStart = address.IndexOf(":", schemeDelimiterEnd + unixPipeHostPrefixLength, StringComparison.Ordinal);`
	`182`	`+ pathDelimiterStart = address.IndexOf(':', schemeDelimiterEnd + unixPipeHostPrefixLength);`
`183`	`183`	`pathDelimiterEnd = pathDelimiterStart + ":".Length;`
`184`	`184`	`}`
`185`	`185`	`else if (isNamedPipe)`
`186`	`186`	`{`
`187`		`- pathDelimiterStart = address.IndexOf(":", schemeDelimiterEnd + NamedPipeHostPrefix.Length, StringComparison.Ordinal);`
	`187`	`+ pathDelimiterStart = address.IndexOf(':', schemeDelimiterEnd + NamedPipeHostPrefix.Length);`
`188`	`188`	`pathDelimiterEnd = pathDelimiterStart + ":".Length;`
`189`	`189`	`}`
`190`	`190`	`else`
`191`	`191`	`{`
`192`		`- pathDelimiterStart = address.IndexOf("/", schemeDelimiterEnd, StringComparison.Ordinal);`
	`192`	`+ pathDelimiterStart = address.IndexOf('/', schemeDelimiterEnd);`
`193`	`193`	`pathDelimiterEnd = pathDelimiterStart;`
`194`	`194`	`}`
`195`	`195`
`@@ -205,7 +205,7 @@ public static BindingAddress Parse(string address)`
`205`	`205`	`var hasSpecifiedPort = false;`
`206`	`206`	`if (!isUnixPipe)`
`207`	`207`	`{`
`208`		`- var portDelimiterStart = address.LastIndexOf(":", pathDelimiterStart - 1, pathDelimiterStart - schemeDelimiterEnd, StringComparison.Ordinal);`
	`208`	`+ var portDelimiterStart = address.LastIndexOf(':', pathDelimiterStart - 1, pathDelimiterStart - schemeDelimiterEnd);`
`209`	`209`	`if (portDelimiterStart >= 0)`
`210`	`210`	`{`
`211`	`211`	`var portDelimiterEnd = portDelimiterStart + ":".Length;`
Original file line number	Diff line number	Diff line change
`@@ -72,19 +72,19 @@ private MediaTypeHeaderValue? ContentType`
`72`	`72`	`{`
`73`	`73`	`get`
`74`	`74`	`{`
`75`		`- MediaTypeHeaderValue? mt = null;`
	`75`	`+ MediaTypeHeaderValue? mt = null;`
`76`	`76`
`77`		`- if (_request is not null)`
`78`		`- {`
`79`		`- _ = MediaTypeHeaderValue.TryParse(_request.ContentType, out mt);`
`80`		`- }`
	`77`	`+ if (_request is not null)`
	`78`	`+ {`
	`79`	`+ _ = MediaTypeHeaderValue.TryParse(_request.ContentType, out mt);`
	`80`	`+ }`
`81`	`81`
`82`		`- if (_form is not null && mt is null)`
`83`		`- {`
`84`		`- mt = _formContentType;`
`85`		`- }`
	`82`	`+ if (_form is not null && mt is null)`
	`83`	`+ {`
	`84`	`+ mt = _formContentType;`
	`85`	`+ }`
`86`	`86`
`87`		`- return mt;`
	`87`	`+ return mt;`
`88`	`88`	`}`
`89`	`89`	`}`
`90`	`90`
`@@ -127,9 +127,9 @@ public IFormCollection? Form`
`127`	`127`	`{`
`128`	`128`	`_formContentType = null;`
`129`	`129`	`}`
`130`		`- else`
	`130`	`+ else`
`131`	`131`	`{`
`132`		`- _formContentType ??= new MediaTypeHeaderValue("application/x-www-form-urlencoded");`
	`132`	`+ _formContentType ??= new MediaTypeHeaderValue("application/x-www-form-urlencoded");`
`133`	`133`	`}`
`134`	`134`	`}`
`135`	`135`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public override string ToString()`
`53`	`53`	`{`
`54`	`54`	`var hostsDisplay = (Hosts.Count == 0)`
`55`	`55`	`? ":"`
`56`		`- : string.Join(",", Hosts.Select(h => h.Contains(':') ? h : h + ":*"));`
	`56`	`+ : string.Join(',', Hosts.Select(h => h.Contains(':') ? h : h + ":*"));`
`57`	`57`
`58`	`58`	`return DebuggerHelpers.GetDebugText(nameof(Hosts), hostsDisplay);`
`59`	`59`	`}`
Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public static CompositeBindingSource Create(`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`
`56`		`- var id = string.Join("&", bindingSources.Select(s => s.Id).OrderBy(s => s, StringComparer.Ordinal));`
	`56`	`+ var id = string.Join('&', bindingSources.Select(s => s.Id).OrderBy(s => s, StringComparer.Ordinal));`
`57`	`57`	`return new CompositeBindingSource(id, displayName, bindingSources);`
`58`	`58`	`}`
`59`	`59`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public virtual async Task<AuthenticateResult> AuthenticateAsync(AuthorizationPol`
`54`	`54`	`if (newPrincipal != null)`
`55`	`55`	`{`
`56`	`56`	`context.User = newPrincipal;`
`57`		`- var ticket = new AuthenticationTicket(newPrincipal, string.Join(";", policy.AuthenticationSchemes));`
	`57`	`+ var ticket = new AuthenticationTicket(newPrincipal, string.Join(';', policy.AuthenticationSchemes));`
`58`	`58`	`// ExpiresUtc is the easiest property to reason about when dealing with multiple schemes`
`59`	`59`	`// SignalR will use this property to evaluate auth expiration for long running connections`
`60`	`60`	`ticket.Properties.ExpiresUtc = minExpiresUtc;`