Merge | TdsParserStateObject lifetime-related methods #3394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also move ReadSyncOverAsync down in netcore's TdsParserStateObjectNative to aid later merge
Also reorder member in TdsParserStateObjectNative to simplify later merge
This also allows _writePacketCache to be migrated to TdsParserStateObjectNative in netfx.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3394 +/- ##
==========================================
- Coverage 63.51% 60.03% -3.48%
==========================================
Files 293 285 -8
Lines 63810 63405 -405
==========================================
- Hits 40526 38067 -2459
- Misses 23284 25338 +2054
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/azp run |
benrr101
added
the
Common Project 🚮
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
previously approved these changes
Jun 23, 2025
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/TdsParserStateObject.cs
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParserStateObjectNative.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
benrr101
previously approved these changes
Jun 26, 2025
mdaigle
previously approved these changes
Jul 1, 2025
| @@ -408,28 +414,17 @@ internal void Connect(ServerInfo serverInfo, | |||
| } | |||
| } | |||
|
|
|||
| _serverSpn = null; | |||
There was a problem hiding this comment.
Thanks - removed from netfx and netcore.
|
/azp run |
benrr101
approved these changes
Jul 8, 2025
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're now merging the lifetime-related methods on TdsParserStateObject in netfx, making them abstract and pushing them down to the derived TdsParserStateObjectNative class. This also handles some slightly unusual logic in
CreatePhysicalSNIHandle, sincespnsis a string in netfx and a string array in netcore. I've needed to merge this type handling too.Commit 469d840 onwards moves method-by-method. I've moved:
Relates to #1261.