Remove redundant assignment to _serverSpn

edwardneal · edwardneal · commit 879246a2bdb0 · 2025-07-02T21:32:52.000+01:00
diff --git a/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.cs
@@ -395,7 +395,6 @@ internal void Connect(ServerInfo serverInfo,
             }
             else
             {
-                _serverSpn = null;
                 SqlClientEventSource.Log.TryTraceEvent("TdsParser.Connect | SEC | Connection Object Id {0}, Authentication Mode: {1}", _connHandler.ObjectID,
                     authType == SqlAuthenticationMethod.NotSpecified ? SqlAuthenticationMethod.SqlPassword.ToString() : authType.ToString());
             }
diff --git a/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs b/src/Microsoft.Data.SqlClient/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs
@@ -397,7 +397,6 @@ internal void Connect(ServerInfo serverInfo,
             }
             else
             {
-                _serverSpn = null;
                 SqlClientEventSource.Log.TryTraceEvent("TdsParser.Connect | SEC | Connection Object Id {0}, Authentication Mode: {1}", _connHandler.ObjectID,
                     authType == SqlAuthenticationMethod.NotSpecified ? SqlAuthenticationMethod.SqlPassword.ToString() : authType.ToString());
             }

Original file line number	Diff line number	Diff line change
`@@ -395,7 +395,6 @@ internal void Connect(ServerInfo serverInfo,`
`395`	`395`	`}`
`396`	`396`	`else`
`397`	`397`	`{`
`398`		`- _serverSpn = null;`
`399`	`398`	`SqlClientEventSource.Log.TryTraceEvent("TdsParser.Connect \| SEC \| Connection Object Id {0}, Authentication Mode: {1}", _connHandler.ObjectID,`
`400`	`399`	`authType == SqlAuthenticationMethod.NotSpecified ? SqlAuthenticationMethod.SqlPassword.ToString() : authType.ToString());`
`401`	`400`	`}`
Original file line number	Diff line number	Diff line change
`@@ -397,7 +397,6 @@ internal void Connect(ServerInfo serverInfo,`
`397`	`397`	`}`
`398`	`398`	`else`
`399`	`399`	`{`
`400`		`- _serverSpn = null;`
`401`	`400`	`SqlClientEventSource.Log.TryTraceEvent("TdsParser.Connect \| SEC \| Connection Object Id {0}, Authentication Mode: {1}", _connHandler.ObjectID,`
`402`	`401`	`authType == SqlAuthenticationMethod.NotSpecified ? SqlAuthenticationMethod.SqlPassword.ToString() : authType.ToString());`
`403`	`402`	`}`