WN: WebSocket Keep-Alive Timeout: Edit & code moved to project #33460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added the include under "Miscellaneous". If you would rather it be in its own new section for WebSockets or something similar, I'll do that instead. I felt like I should add a definition for "pong frame" but then figured we might expect the target audience to be aware already of ping vs pong. |
tdykstra
approved these changes
Aug 27, 2024
aspnetcore/release-notes/aspnetcore-9/includes/websockets-keep-alive-timeout.md
Outdated
Show resolved
Hide resolved
aspnetcore/release-notes/aspnetcore-9/samples/WebSocketsKeepAliveTimeoutExample/Program.cs
Outdated
Show resolved
Hide resolved
|
Added all suggestions. |
aspnetcore/release-notes/aspnetcore-9/includes/websockets-keep-alive-timeout.md
Outdated
Show resolved
Hide resolved
BrennanConroy
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33462
Edit from original provided in discussion from Brennan for issue: #33442
Moved inline code samples to a project, using a bare bones of our original WebSockets sample already available.
The changes to aspnetcore/release-notes/aspnetcore-9.0.md are just so we can see what the include looks like in a build.
That will be removed before merge. We will add all the includes to the main document closer to publishing.
Internal previews