Skip to content

WN9.7: Move non-blazor embedded snippets to project #33354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rick-Anderson opened this issue Aug 13, 2024 · 3 comments
Closed

WN9.7: Move non-blazor embedded snippets to project #33354

Rick-Anderson opened this issue Aug 13, 2024 · 3 comments
Assignees
Labels
9.0 .NET 9 aspnet-core/svc doc-bug release-notes/subsvc seQUESTered Identifies that an issue has been imported into Quest.

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Aug 13, 2024

Description

Our policy is to NOT use embedded snippets. For .NET 10 previews, we should aim to have Compilable code :::code language="csharp" source="~/fundamentals/Program.cs" id="snippet_1" highlight="1":::

image

Every snipped I migrated to a project had at least 1 compiler error I fixes.
Record how many snippets you had to change here.

Page URL

https://learn.microsoft.com/en-us/aspnet/core/release-notes/aspnetcore-9.0?view=aspnetcore-8.0

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/release-notes/aspnetcore-9.0.md

Document ID

4e75ad25-2c3f-b28e-6a91-ac79a9c683b6

Article author

@Rick-Anderson


Associated WorkItem - 302691

@wadepickett
Copy link
Contributor

wadepickett commented Aug 13, 2024

What's new PR entries where I also moved the code to projects and linked back in. For each one the code sample was created inline by the dev team and I went back and created an ASP.NET project for it with working code, tested and linked the code back in.

PR #33318
Moved the original inline code from dev for What's New .NET 9 Prev 7 for the SignalR section to a project that was compiled and tested.

PR #33460
Moved the original inline code from dev for What's New .NET 9 RC1 for WebSockets Keep-Alive Timeout to a project.

PR #34183
Recreated both SignalR ActivitySource examples for both client and server into an app project and the linked back in.

@tdykstra tdykstra added reQUEST Triggers an issue to be imported into Quest and removed Source - Docs.ms Docs Customer feedback via GitHub Issue labels Aug 28, 2024
@sequestor sequestor bot added seQUESTered Identifies that an issue has been imported into Quest. and removed reQUEST Triggers an issue to be imported into Quest labels Aug 28, 2024
@tdykstra tdykstra added the 9.0 .NET 9 label Aug 28, 2024
@dotnetrepoman dotnetrepoman bot added mapQuest clean move and removed mapQuest clean move labels Oct 1, 2024
@Rick-Anderson Rick-Anderson removed their assignment Oct 1, 2024
@dotnetrepoman dotnetrepoman bot removed the mapQuest clean move label Oct 1, 2024
@tdykstra tdykstra removed this from Next sprint Nov 14, 2024
@dotnetrepoman dotnetrepoman bot added mapQuest clean move and removed mapQuest clean move labels Nov 20, 2024
@wadepickett
Copy link
Contributor

@tdykstra , I'm completed with this (PR's listed above). Can we close this or do you still have some to do? If so, I might move my name to a separate tracking issue and close it for November and refer back to this one.

@tdykstra
Copy link
Contributor

tdykstra commented Dec 3, 2024

Close

@dotnetrepoman dotnetrepoman bot added mapQuest clean move and removed mapQuest clean move labels Dec 3, 2024
@dotnetrepoman dotnetrepoman bot added the mapQuest clean move label Mar 4, 2025
@wadepickett wadepickett moved this from 🔖 Ready to ✅ Done in dotnet/AspNetCore.Docs October 2024 sprint Mar 4, 2025
@dotnet-policy-service dotnet-policy-service bot removed the mapQuest clean move label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9.0 .NET 9 aspnet-core/svc doc-bug release-notes/subsvc seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
Development

No branches or pull requests

4 participants