Refactor: 프로젝트의 전반적인 리팩토링 #83
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| 'use client'; | ||
|
|
||
| import { QueryAsyncBoundary } from '@suspensive/react-query'; | ||
|
|
||
| import FeedContent from './FeedContent'; | ||
| import FilterSheet from './FilterSheet'; | ||
| import { RejectedFallback } from '@/components/ErrorBoundary'; | ||
| import { Loading } from '@/components/Loading'; | ||
| import { PageAnimation } from '@/components/PageAnimation'; | ||
|
|
||
| export default function FeedComponent() { | ||
| return ( | ||
| <QueryAsyncBoundary | ||
| rejectedFallback={RejectedFallback} | ||
| pendingFallback={<Loading className="h-[calc(100dvh-178px)]" />} | ||
| > | ||
| <PageAnimation> | ||
| <FeedContent /> | ||
| <FilterSheet /> | ||
| </PageAnimation> | ||
| </QueryAsyncBoundary> | ||
| ); | ||
| } | ||
|
There was a problem hiding this comment. 이 코드는 상대적으로 깔끔해 보입니다. 개선을 위한 제안은 다음과 같습니다:
이상은 해당 코드에서 발견된 개선 사항 및 잠재적 위험 사항 중 규모가 있는 것들입니다. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,5 @@ | ||
| import FeedComponent from './FeedComponent'; | ||
|
|
||
| export default function Feed() { | ||
| return <FeedComponent />; | ||
| } | ||
|
There was a problem hiding this comment. 이 코드 패치의 간단한 코드 리뷰를 도와드리겠습니다. 개선 제안:
버그 위험:
총평: |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| 'use client'; | ||
|
|
||
| import { PrimaryButton } from '@/components/Button'; | ||
| import EmptyCase from '@/components/Feed/EmptyCase'; | ||
| import { PreparingPopup } from '@/components/Modal'; | ||
| import { useOverlay } from '@/components/Overlay/useOverlay'; | ||
|
|
||
| export default function MyPoseComponent() { | ||
| const { open } = useOverlay(); | ||
|
|
||
| return ( | ||
| <EmptyCase | ||
| title={'나만의 포즈를 추가해 보세요!'} | ||
| text={'포즈피드에 네컷사진을 업로드할 수 있어요'} | ||
| > | ||
| <PrimaryButton | ||
| onClick={() => open(({ exit }) => <PreparingPopup onClose={exit} />)} | ||
| text="포즈 등록하기" | ||
| variant="secondary" | ||
| /> | ||
| </EmptyCase> | ||
| ); | ||
| } | ||
|
There was a problem hiding this comment. 주요 내용:
잠재적인 버그 리스크:
개선 제안:
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,7 @@ | ||
| 'use client'; | ||
|
|
||
| import MyPoseComponent from './MyPoseComponent'; | ||
|
|
||
| export default function Page() { | ||
| return <MyPoseComponent />; | ||
| } | ||
|
There was a problem hiding this comment. 이 코드 패치의 코드 리뷰:
개선을 위해서는 페이지의 전반적인 목적과 UI 요소들 간 상호 작용에 대한 이해가 필요합니다. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| 'use client'; | ||
|
|
||
| import { delay } from 'es-toolkit'; | ||
| import { useState } from 'react'; | ||
| import Lottie from 'react-lottie-player'; | ||
|
|
||
| import lottiePick from '#/lotties/pick.json'; | ||
| import { usePosePickQuery } from '@/apis'; | ||
| import { BottomFixedDiv, PrimaryButton } from '@/components/Button'; | ||
| import PoseImage from '@/components/Modal/PoseImage'; | ||
| import { SelectionBasic } from '@/components/Selection'; | ||
| import { peopleCountList } from '@/constants'; | ||
| import { useDidMount } from '@/hooks'; | ||
|
|
||
| const DEFAULT_IMAGE = '/images/image-frame.png'; | ||
|
|
||
| export default function PickComponent() { | ||
| const [countState, setCountState] = useState(1); | ||
| const [isLottiePlaying, setIsLottiePlaying] = useState(true); | ||
| const { refetch, data } = usePosePickQuery(countState); | ||
| const imageSrc = data?.poseInfo?.imageKey || DEFAULT_IMAGE; | ||
|
|
||
| useDidMount(async () => { | ||
| await delay(2200); | ||
| setIsLottiePlaying(false); | ||
| }); | ||
|
|
||
| const handlePickClick = async () => { | ||
| refetch(); | ||
| setIsLottiePlaying(true); | ||
| await delay(900); | ||
| setIsLottiePlaying(false); | ||
| }; | ||
|
|
||
| return ( | ||
| <> | ||
| <div className="py-16"> | ||
| <SelectionBasic | ||
| data={peopleCountList.slice(1)} | ||
| state={countState} | ||
| setState={setCountState} | ||
| /> | ||
| </div> | ||
| <div className="relative flex grow"> | ||
| {isLottiePlaying && ( | ||
| <div className="absolute inset-x-0 inset-y-0 z-10 flex justify-center bg-black"> | ||
| <Lottie animationData={lottiePick} play /> | ||
| </div> | ||
| )} | ||
| <div className="absolute inset-x-0 inset-y-0 bg-black"> | ||
| <PoseImage src={imageSrc} /> | ||
| </div> | ||
| </div> | ||
| <BottomFixedDiv> | ||
| <PrimaryButton | ||
| text={!!imageSrc ? `${countState}인 포즈 뽑기` : '인원수 선택하고 포즈 뽑기'} | ||
| onClick={handlePickClick} | ||
| /> | ||
| </BottomFixedDiv> | ||
| </> | ||
| ); | ||
| } | ||
|
There was a problem hiding this comment. 이 코드에 대한 간단한 코드 리뷰를 해보겠습니다.
코드 품질을 향상시키고 유지보수성을 높이기 위해 주의깊게 검토해 보시길 바랍니다. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이 코드 패치는 새로운 패키지(
es-toolkit) 추가와 의존성 버전 업데이트를 포함하고 있습니다.개선 제안:
"es-toolkit"의 올바른 사용을 확인하세요.