Refactor: 프로젝트의 전반적인 리팩토링 #83
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: 'CI' | ||
| on: | ||
| pull_request: | ||
| types: [opened, synchronize, reopened] | ||
| jobs: | ||
| ci: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
|
|
||
| - name: Install dependencies | ||
| run: yarn install --frozen-lockfile | ||
|
|
||
| - name: Check typescript | ||
| run: yarn type:check | ||
|
|
||
| - name: Check eslint | ||
| run: yarn lint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import AppDownloadBanner from '../../components/Header/AppDownloadBanner'; | ||
| import { StrictPropsWithChildren } from '@/types'; | ||
| import { isIOS } from '@/utils'; | ||
|
|
||
| export function MainFooter({ children }: StrictPropsWithChildren) { | ||
| return ( | ||
| <> | ||
| <div className="fixed inset-x-0 bottom-0 z-30"> | ||
| <div className="mx-auto max-w-layout bg-white px-20 pb-24 pt-10"> | ||
| <div className="flex gap-8 [&>*]:flex-1 [&>*]:grow">{children}</div> | ||
| </div> | ||
| {isIOS() && <AppDownloadBanner />} | ||
| </div> | ||
| <div className="h-88" /> | ||
| </> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| 'use client'; | ||
|
|
||
| import { QueryAsyncBoundary } from '@suspensive/react-query'; | ||
|
|
||
| import FeedContent from './FeedContent'; | ||
| import FilterSheet from './FilterSheet'; | ||
| import { RejectedFallback } from '@/components/ErrorBoundary'; | ||
| import { Loading } from '@/components/Loading'; | ||
| import { PageAnimation } from '@/components/PageAnimation'; | ||
|
|
||
| export default function FeedComponent() { | ||
| return ( | ||
| <QueryAsyncBoundary | ||
| rejectedFallback={RejectedFallback} | ||
| pendingFallback={<Loading className="h-[calc(100dvh-178px)]" />} | ||
| > | ||
| <PageAnimation> | ||
| <FeedContent /> | ||
| <FilterSheet /> | ||
| </PageAnimation> | ||
| </QueryAsyncBoundary> | ||
| ); | ||
| } | ||
|
There was a problem hiding this comment. 이 코드는 상대적으로 깔끔해 보입니다. 개선을 위한 제안은 다음과 같습니다:
이상은 해당 코드에서 발견된 개선 사항 및 잠재적 위험 사항 중 규모가 있는 것들입니다. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,5 @@ | ||
| import FeedComponent from './FeedComponent'; | ||
|
|
||
| export default function Feed() { | ||
| return <FeedComponent />; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| 'use client'; | ||
|
|
||
| import { PrimaryButton } from '@/components/Button'; | ||
| import EmptyCase from '@/components/Feed/EmptyCase'; | ||
| import { PreparingPopup } from '@/components/Modal'; | ||
| import { useOverlay } from '@/components/Overlay/useOverlay'; | ||
|
|
||
| export default function MyPoseComponent() { | ||
| const { open } = useOverlay(); | ||
|
|
||
| return ( | ||
| <EmptyCase | ||
| title={'나만의 포즈를 추가해 보세요!'} | ||
| text={'포즈피드에 네컷사진을 업로드할 수 있어요'} | ||
| > | ||
| <PrimaryButton | ||
| onClick={() => open(({ exit }) => <PreparingPopup onClose={exit} />)} | ||
| text="포즈 등록하기" | ||
| variant="secondary" | ||
| /> | ||
| </EmptyCase> | ||
| ); | ||
| } | ||
|
There was a problem hiding this comment. 주요 내용:
잠재적인 버그 리스크:
개선 제안:
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 리뷰를 진행하겠습니다:
버그 위험:
BASE_API_URL이 상수로 사용되는 데, 코드의 4번째 줄에서 재선언됨으로써 중복 정의 문제가 발생할 수 있음.개선 제안:
이외에도 API URL, 상수, 유틸리티 함수 등을 더 깊이 파악하기 위해 전체 코드베이스의 컨텍스트를 파악하는 것이 유용할 수 있습니다.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
95a534c