chore(Client): robust error checking #9390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Jiralite
requested changes
Apr 14, 2023
Jiralite
requested changes
Apr 15, 2023
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
…n/discord.js-fork into chore/robust-errors
TetieWasTaken
changed the title
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-tetiewastaken-chore-robust-errors-discordjs.vercel.app/ |
SpaceEEC
approved these changes
Apr 15, 2023
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
TetieWasTaken
force-pushed
the
chore/robust-errors
branch
from
e34ef81 to
26f404b
Compare
…n/discord.js-fork into chore/robust-errors
Jiralite
requested changes
Apr 17, 2023
Jiralite
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Making this because branch at #9325 was messed up.
🤖 Generated by Copilot at ecb068b
Summary
📝🛠️🚫
This pull request improves the error handling and validation of the
Clientconstructor and its options. It adds a new custom error typeInvalidScopeWithPermissionsand a corresponding message template for when a bot requests a scope that requires permissions it does not have.Walkthrough
permissionsoption is only used withbotscope inClientconstructor (packages/discord.js/src/client/Client.js) and throwDiscordjsTypeErrorwith codeInvalidScopeWithPermissionsif not (link)allowedMentions,presence,ws,rest, andjsonTransformeroptions are of the expected types inClientconstructor (packages/discord.js/src/client/Client.js) and throwDiscordjsTypeErrorwith codeClientInvalidOptionif not (link)InvalidScopeWithPermissionsproperty toErrorCodesenum (packages/discord.js/src/errors/ErrorCodes.js) andkeysarray (link, link)InvalidScopeWithPermissionserror code toMessagesobject (packages/discord.js/src/errors/Messages.js) (link)Status and versioning classification: