Skip to content

chore: expand error feedback #9325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

TetieWasTaken
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR adds more robust error checking in Client#_validateOptions() and Client#generateInvite()

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Apr 14, 2023 3:06pm
discord-js-guide ⬜️ Ignored (Inspect) Apr 14, 2023 3:06pm

@vercel
Copy link

vercel bot commented Apr 3, 2023

@TetieWasTaken is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@TetieWasTaken TetieWasTaken force-pushed the chore/client branch 2 times, most recently from d00fb6a to e96d674 Compare April 9, 2023 11:18
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes allowedMentions a required property. This is breaking.

@TetieWasTaken
Copy link
Contributor Author

TetieWasTaken commented Apr 14, 2023

Oops I messed up the branch... (I'll try to fix it once I'm done with stuff, in a couple of hours)

@github-actions
Copy link

📦 Next.js Bundle Analysis for @discordjs/website

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@TetieWasTaken
Copy link
Contributor Author

Closing this in favour of #9390

@TetieWasTaken TetieWasTaken deleted the chore/client branch April 14, 2023 19:55
@almeidx almeidx removed the blocked label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants