Skip to content

fix: regression in allowedMentions when replying #10866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 2, 2025

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented Apr 29, 2025

Please describe the changes this PR makes and why it should be merged:

Fixes #10865

Only bumps zlib-sync for development pipeline purposes. No releases of @discordjs/ws are ever done from the target branch.

Status and versioning classification:

@Qjuh Qjuh requested a review from a team as a code owner April 29, 2025 16:08
@Qjuh Qjuh requested review from vladfrangu, iCrawl, kyranet and SpaceEEC and removed request for a team April 29, 2025 16:08
Copy link

vercel bot commented Apr 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 1, 2025 7:39pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 1, 2025 7:39pm

Copy link

vercel bot commented Apr 29, 2025

@Qjuh is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@Jiralite Jiralite added this to the discord.js 14.19 milestone Apr 29, 2025
@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 30, 2025
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the tests should also deal with assertions?

@github-project-automation github-project-automation bot moved this from Review Approved to Review in Progress in discord.js Apr 30, 2025
@Qjuh Qjuh requested a review from vladfrangu April 30, 2025 19:35
Copy link

vercel bot commented Apr 30, 2025

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@Qjuh Qjuh requested a review from a team as a code owner May 1, 2025 19:39
@Qjuh Qjuh requested review from didinele and removed request for a team May 1, 2025 19:39
@Qjuh Qjuh merged commit 2ebb5cb into discordjs:v14 May 2, 2025
27 checks passed
@github-project-automation github-project-automation bot moved this from Review in Progress to Done in discord.js May 2, 2025
@Qjuh Qjuh deleted the fix/allowed-mentions-reply branch May 2, 2025 10:49
@Qjuh Qjuh mentioned this pull request May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants