Skip to content

feat: components v2 #10847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
May 11, 2025
Merged

feat: components v2 #10847

merged 19 commits into from
May 11, 2025

Conversation

Qjuh
Copy link
Member

@Qjuh Qjuh commented Apr 25, 2025 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

Forward-port of

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel Vercel
Copy link

vercel bot commented Apr 25, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 11, 2025 8:42pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 11, 2025 8:42pm

@Qjuh Qjuh added this to the discord.js 15.0.0 milestone Apr 25, 2025
@Qjuh Qjuh marked this pull request as ready for review April 25, 2025 20:36
@Qjuh Qjuh requested a review from a team as a code owner April 25, 2025 20:36
uwx
uwx reviewed Apr 25, 2025
View reviewed changes
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2025

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

sdanialraza
sdanialraza requested changes May 11, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Todo to Review in Progress in discord.js May 11, 2025
@Qjuh @sdanialraza
Apply suggestions from code review
3d9e6fb 
Co-authored-by: Danial Raza <danialrazafb@gmail.com>
@github-project-automation github-project-automation bot moved this from Review in Progress to Review Approved in discord.js May 11, 2025
@kodiakhq kodiakhq bot merged commit 4f5e5c7 into discordjs:main May 11, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js May 11, 2025
@Qjuh Qjuh deleted the feat/comp-v2 branch May 11, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uwx uwx uwx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@Jiralite Jiralite Jiralite approved these changes

@sdanialraza sdanialraza sdanialraza approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js 15.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Qjuh @uwx @vladfrangu @Jiralite @sdanialraza