Skip to content

ci: update list of packages in codecov uploads #10846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 27, 2025
Merged

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Apr 25, 2025

  • Removed test-related dependencies from website
  • Bumped pnpm
  • guide/website/scripts don't have tests. Removed them from the codecov upload action

Copy link

vercel bot commented Apr 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Apr 27, 2025 0:39am

@almeidx almeidx changed the title Ci/codecov uploads ci: update list of packages in codecov uploads Apr 25, 2025
@almeidx almeidx marked this pull request as ready for review April 25, 2025 14:28
@almeidx almeidx requested review from a team and iCrawl as code owners April 25, 2025 14:28
Copy link

codecov bot commented Apr 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.57%. Comparing base (8f37527) to head (d5af011).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10846      +/-   ##
==========================================
- Coverage   44.60%   42.57%   -2.03%     
==========================================
  Files         260      262       +2     
  Lines       15363    16138     +775     
  Branches     1549     1549              
==========================================
+ Hits         6852     6871      +19     
- Misses       8499     9255     +756     
  Partials       12       12              
Flag Coverage Δ
builders 80.49% <ø> (ø)
core 0.89% <ø> (?)
proxy 65.88% <ø> (ø)
rest 87.76% <ø> (ø)
ws 36.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ckohen
Copy link
Member

ckohen commented Apr 26, 2025

Scripts may have tests so we should keep it imo, it's highly unlikely the other two will though.

@github-project-automation github-project-automation bot moved this from Todo to Review Approved in discord.js Apr 27, 2025
@kodiakhq kodiakhq bot merged commit a4f3a25 into main Apr 27, 2025
25 checks passed
@kodiakhq kodiakhq bot deleted the ci/codecov-uploads branch April 27, 2025 00:45
@github-project-automation github-project-automation bot moved this from Review Approved to Done in discord.js Apr 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants