Skip to content

build(deps)!: bump io.github.jeremylong:open-vulnerability-clients from 7.3.2 to 8.0.0 #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -316,11 +316,12 @@ private boolean processApi() throws UpdateException {
//using a higher delay as the system may not be able to process these faster.
builder.withApiKey(key)
.withDelay(5000)
.withThreadCount(4);
.withrequestsPerThirtySeconds(settings.getInt(Settings.KEYS.NVD_API_REQUESTS_PER_30_SECONDS_WITH_API_KEY, 50));
} else {
LOGGER.warn("An NVD API Key was not provided - it is highly recommended to use "
+ "an NVD API key as the update can take a VERY long time without an API Key");
builder.withDelay(10000);
builder.withDelay(10000)
.withrequestsPerThirtySeconds(settings.getInt(Settings.KEYS.NVD_API_REQUESTS_PER_30_SECONDS_WITHOUT_API_KEY, 5));
}

final int resultsPerPage = Math.min(settings.getInt(Settings.KEYS.NVD_API_RESULTS_PER_PAGE, RESULTS_PER_PAGE), RESULTS_PER_PAGE);
Expand Down
2 changes: 2 additions & 0 deletions core/src/main/resources/dependencycheck.properties
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ nvd.api.check.validforhours=4
nvd.api.datafeed.validfordays=7
nvd.api.max.retry.count=30
nvd.api.delay=0
nvd.api.requestsperthirtysecondswithoutapikey=5
nvd.api.requestsperthirtysecondswithapikey=50
#nvd.api.datafeed.url=https://example.com/nvd-cache/
#nvd.api.datafeed.user=
#nvd.api.datafeed.password=
Expand Down
2 changes: 2 additions & 0 deletions core/src/test/resources/dependencycheck.properties
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ nvd.api.check.validforhours=4
nvd.api.datafeed.validfordays=7
nvd.api.max.retry.count=30
nvd.api.delay=0
nvd.api.requestsperthirtysecondswithoutapikey=5
nvd.api.requestsperthirtysecondswithapikey=50
#nvd.api.datafeed.url=https://example.com/nvd-cache/
#nvd.api.datafeed.user=
#nvd.api.datafeed.password=
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@ Copyright (c) 2012 - Jeremy Long
<dependency>
<groupId>io.github.jeremylong</groupId>
<artifactId>open-vulnerability-clients</artifactId>
<version>7.3.2</version>
<version>8.0.0</version>
</dependency>
<dependency>
<groupId>org.anarres.jdiagnostics</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,14 @@ public static final class KEYS {
* The delay between requests for the NVD API.
*/
public static final String NVD_API_DELAY = "nvd.api.delay";
/**
* The number of requests made to the NVD API per 30 seconds when no API KEY is provided.
*/
public static final String NVD_API_REQUESTS_PER_30_SECONDS_WITHOUT_API_KEY = "nvd.api.requestsperthirtysecondswithoutapikey";
/**
* The number of requests made to the NVD API per 30 seconds when an API KEY is provided.
*/
public static final String NVD_API_REQUESTS_PER_30_SECONDS_WITH_API_KEY = "nvd.api.requestsperthirtysecondswithapikey";
/**
* The maximum number of retry requests for a single call to the NVD
* API.
Expand Down
2 changes: 2 additions & 0 deletions utils/src/test/resources/dependencycheck.properties
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,8 @@ nvd.api.check.validforhours=4
nvd.api.datafeed.validfordays=7
nvd.api.max.retry.count=30
nvd.api.delay=0
nvd.api.requestsperthirtysecondswithoutapikey=5
nvd.api.requestsperthirtysecondswithapikey=50
#nvd.api.datafeed.url=https://example.com/nvd-cache/
#nvd.api.datafeed.user=
#nvd.api.datafeed.password=
Expand Down