Skip to content

build(deps)!: bump io.github.jeremylong:open-vulnerability-clients from 7.3.2 to 8.0.0 #7630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 5, 2025

Bumps io.github.jeremylong:open-vulnerability-clients from 7.3.2 to 8.0.0.

Release notes

Sourced from io.github.jeremylong:open-vulnerability-clients's releases.

v8.0.0

What's Changed

Full Changelog: jeremylong/open-vulnerability-cli@v7.2.2...v8.0.0

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [io.github.jeremylong:open-vulnerability-clients](https://github.com/jeremylong/vuln-tools) from 7.3.2 to 8.0.0.
- [Release notes](https://github.com/jeremylong/vuln-tools/releases)
- [Commits](https://github.com/jeremylong/vuln-tools/commits/v8.0.0)

---
updated-dependencies:
- dependency-name: io.github.jeremylong:open-vulnerability-clients
  dependency-version: 8.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies java Pull requests that update Java code labels May 5, 2025
@jeremylong jeremylong changed the title build(deps): bump io.github.jeremylong:open-vulnerability-clients from 7.3.2 to 8.0.0 build(deps)!: bump io.github.jeremylong:open-vulnerability-clients from 7.3.2 to 8.0.0 May 5, 2025
@boring-cyborg boring-cyborg bot added core changes to core tests test cases utils changes to utils labels May 7, 2025
Copy link
Collaborator

@aikebah aikebah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nhumblot nhumblot self-assigned this May 27, 2025
@aikebah
Copy link
Collaborator

aikebah commented Jul 16, 2025

@nhumblot Think this could be merged too? Or is there a reason to not include it in a minor release of ODC?

@jeremylong
Copy link
Collaborator

I felt this was a breaking change - so I was going to include it in the next major release. At least we should wait for the next minor release as opposed to the pending point release.

@aikebah
Copy link
Collaborator

aikebah commented Jul 16, 2025

While for the library it was a breaking release (split between CLI and the library code as separately released projects), I think for ODC it would not be a non-breaking change.

AFAICT We're only adapting our internals and introducing two configuration properties (not exposed to the plugin configs) - one might consider the added properties a new feature for people using properties-file configurstion, so I can see how you may want to skip the revision level and wait for a feature release, though I would say for a proper feature it should be extended with extending the configurability in the gradle- and maven plugin configuration settings.

@nhumblot
Copy link
Collaborator

nhumblot commented Jul 23, 2025

Hi,

Sorry for the late reply.

I marked commit 8cc9ade with a ! because I thought an upgrade with this change might break for users using the CLI with the -P or --propertyfile option.

Documentation

I have to admit I did not manual test this part extensively. I am going to proceed additional testing and share with you if my initial thought was good or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core changes to core dependencies java Pull requests that update Java code tests test cases utils changes to utils
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants