Skip to content

When Repliction_mode is Async allow RPO to be Set #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2025

Conversation

doriac11
Copy link
Contributor

@doriac11 doriac11 commented Jul 9, 2025

Description

  • If replication mode is async, and rpo is set we need to make sure it gets set properly.
  • Fix github-actions to later version of Python.
  • Fix Linting errors.
  • Fix Copyright.

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, pep8, linting, or security issues
  • I have performed Ansible Sanity test using --docker default
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • FT

@doriac11 doriac11 requested review from varunchinta and shekhar-j July 9, 2025 12:19
@doriac11 doriac11 force-pushed the pub/filesystem-async-rpo branch 9 times, most recently from 15bebf0 to 2e6c8ec Compare July 9, 2025 15:15
shekhar-j
shekhar-j previously approved these changes Jul 9, 2025
@doriac11 doriac11 requested review from baoy1 and P-Cao July 10, 2025 11:52
baoy1
baoy1 previously approved these changes Jul 14, 2025
@doriac11 doriac11 dismissed stale reviews from baoy1 and shekhar-j via 961a646 July 14, 2025 12:34
@doriac11 doriac11 force-pushed the pub/filesystem-async-rpo branch from 2e6c8ec to 961a646 Compare July 14, 2025 12:34
@doriac11 doriac11 merged commit 810ec8e into main Jul 14, 2025
24 checks passed
@doriac11 doriac11 deleted the pub/filesystem-async-rpo branch July 14, 2025 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants