Skip to content

Commit 2e6c8ec

Browse files
committed
When repliction_mode is Async allow RPO to be set
1 parent 4f3ae00 commit 2e6c8ec

35 files changed

+122
-214
lines changed

.github/workflows/ansible-test.yml

Lines changed: 18 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
ansible-version: [stable-2.14, stable-2.15, stable-2.16, devel]
17+
ansible-version: [stable-2.18]
1818
steps:
1919
- name: Check out code
2020
uses: actions/checkout@v3
@@ -31,7 +31,7 @@ jobs:
3131
run: ansible-galaxy collection build --output-path "${GITHUB_WORKSPACE}/.cache/collection-tarballs"
3232

3333
- name: Store migrated collection artifacts
34-
uses: actions/upload-artifact@v1
34+
uses: actions/upload-artifact@v4.4.0
3535
with:
3636
name: collection
3737
path: .cache/collection-tarballs
@@ -50,15 +50,16 @@ jobs:
5050
matrix:
5151
python: ['3.9', '3.10', '3.11']
5252
ansible:
53-
- stable-2.14
5453
- stable-2.15
5554
- stable-2.16
55+
- stable-2.17
56+
- stable-2.18
5657
- devel
5758
exclude:
58-
- ansible: stable-2.16
59-
python: '3.9'
59+
- ansible: stable-2.18
60+
python: '3.10'
6061
- ansible: devel
61-
python: '3.9'
62+
python: '3.10'
6263

6364
steps:
6465
- name: Perform unit testing with ansible-test
@@ -76,21 +77,23 @@ jobs:
7677

7778
sanity:
7879
name: Sanity (Ⓐ${{ matrix.ansible }} with ${{ matrix.python }} python)
80+
runs-on: ubuntu-latest
7981
needs: [build]
8082
strategy:
83+
fail-fast: false
8184
matrix:
82-
python: ['3.9', '3.10', '3.11']
85+
python: ['3.10', '3.11']
8386
ansible:
84-
- stable-2.14
8587
- stable-2.15
8688
- stable-2.16
89+
- stable-2.17
90+
- stable-2.18
8791
- devel
8892
exclude:
89-
- ansible: stable-2.16
90-
python: '3.9'
93+
- ansible: stable-2.18
94+
python: '3.10'
9195
- ansible: devel
92-
python: '3.9'
93-
runs-on: ubuntu-latest
96+
python: '3.10'
9497
steps:
9598
- name: Perform sanity testing
9699
uses: ansible-community/ansible-test-gh-action@release/v1
@@ -108,14 +111,8 @@ jobs:
108111
strategy:
109112
fail-fast: false
110113
matrix:
111-
python-version: ["3.9", "3.10", "3.11"]
112-
ansible-version: [stable-2.14, stable-2.15, stable-2.16, devel]
113-
exclude:
114-
# Ansible-core 2.16 is supported only from Python 3.10 onwards
115-
- python-version: "3.9"
116-
ansible-version: stable-2.16
117-
- python-version: '3.9'
118-
ansible-version: devel
114+
python-version: ["3.11"]
115+
ansible-version: [stable-2.18, devel]
119116

120117
steps:
121118
# Important: This sets up your GITHUB_WORKSPACE environment variable
@@ -136,7 +133,7 @@ jobs:
136133
run: pip install ansible-lint --disable-pip-version-check
137134

138135
- name: Download migrated collection artifacts
139-
uses: actions/download-artifact@v1
136+
uses: actions/download-artifact@v4.1.8
140137
with:
141138
name: collection
142139
path: .cache/collection-tarballs

.gitignore

Lines changed: 44 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,44 @@
1+
output
2+
3+
# Byte-compiled Python files
4+
*.pyc
5+
*.pyo
6+
__pycache__/
7+
8+
# Virtual environment directories
9+
venv/
10+
.env/
11+
12+
# Distribution packages
13+
dist/
14+
build/
15+
*.egg-info/
16+
17+
# Ansible-related temporary files
18+
*.retry
19+
.cache/
20+
21+
# Test coverage reports
22+
htmlcov/
23+
.coverage
24+
.tox/
25+
26+
# Editor-specific files
27+
.idea/
28+
.vscode/
29+
*.swp
30+
*~
31+
32+
# System-specific files
33+
.DS_Store
34+
Thumbs.db
35+
36+
# Log files
37+
*.log
38+
39+
# Ignore secrets or configuration files
40+
secrets.yml
41+
config.yml
42+
43+
# ansible-galaxy build output files
44+
*.tar.gz

playbooks/modules/cifsserver.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@
126126
state: "absent"
127127
check_mode: true
128128

129-
- name: Delete CIFS server
129+
- name: Delete CIFS server with domain
130130
dellemc.unity.cifsserver:
131131
unispherehost: "{{ unispherehost }}"
132132
username: "{{ username }}"

playbooks/modules/filesystem.yml

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -140,19 +140,6 @@
140140
is_smb_notify_on_access_enabled: true
141141
state: "present"
142142

143-
- name: Modify FileSystem smb_properties - Idempotency
144-
dellemc.unity.filesystem:
145-
unispherehost: "{{ unispherehost }}"
146-
username: "{{ username }}"
147-
password: "{{ password }}"
148-
validate_certs: "{{ validate_certs }}"
149-
filesystem_id: "{{ filesystem_id }}"
150-
smb_properties:
151-
is_smb_op_locks_enabled: true
152-
smb_notify_on_change_dir_depth: 5
153-
is_smb_notify_on_access_enabled: true
154-
state: "present"
155-
156143
- name: Modify FileSystem snap schedule
157144
dellemc.unity.filesystem:
158145
unispherehost: "{{ unispherehost }}"

playbooks/modules/host.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
description: "ansible-test-host-1"
2727
state: "present"
2828

29-
- name: Set host_id
29+
- name: Set host_id empty host
3030
ansible.builtin.set_fact:
3131
host_id_1: "{{ result.host_details.id }}"
3232

playbooks/modules/nfsserver.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
nas_server_name: "dummy_nas"
5252
state: "present"
5353

54-
- name: Delete NFS server
54+
- name: Delete NFS server with windows kdctype
5555
dellemc.unity.nfsserver:
5656
unispherehost: "{{ unispherehost }}"
5757
username: "{{ username }}"

playbooks/modules/replication_session.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,15 +11,15 @@
1111
session_name: "test-session"
1212

1313
tasks:
14-
- name: Get replication session details
14+
- name: Get replication session details using name
1515
dellemc.unity.replication_session:
1616
unispherehost: "{{ unispherehost }}"
1717
username: "{{ username }}"
1818
password: "{{ password }}"
1919
validate_certs: "{{ validate_certs }}"
2020
session_name: "{{ session_name }}"
2121

22-
- name: Get replication session details
22+
- name: Get replication session details using ID
2323
dellemc.unity.replication_session:
2424
unispherehost: "{{ unispherehost }}"
2525
username: "{{ username }}"

playbooks/modules/smbshare.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@
143143
is_encryption_enabled: true
144144
state: "present"
145145

146-
- name: Set Snapshot SMB Share ID
146+
- name: Set Snapshot SMB Share ID for Snapshot
147147
ansible.builtin.set_fact:
148148
snap_share_id: "{{ smb_result.smb_share_details.id }}"
149149

@@ -165,7 +165,7 @@
165165
is_encryption_enabled: true
166166
state: "present"
167167

168-
- name: Get SMB Share Details using Name
168+
- name: Get SMB Share Details using Name for Snapshot
169169
dellemc.unity.smbshare:
170170
unispherehost: "{{ unispherehost }}"
171171
username: "{{ username }}"
@@ -175,7 +175,7 @@
175175
snapshot_name: "{{ snapshot_name }}"
176176
state: "present"
177177

178-
- name: Update the details of the SMB share
178+
- name: Update the details of the SMB share for Snapshot
179179
dellemc.unity.smbshare:
180180
unispherehost: "{{ unispherehost }}"
181181
username: "{{ username }}"
@@ -192,7 +192,7 @@
192192
is_encryption_enabled: false
193193
state: "present"
194194

195-
- name: Update the details of the SMB share Idempotency
195+
- name: Update the details of the SMB share for Snapshot Idempotency
196196
dellemc.unity.smbshare:
197197
unispherehost: "{{ unispherehost }}"
198198
username: "{{ username }}"

playbooks/modules/snapshot.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666
host_state: "mapped"
6767
state: "present"
6868

69-
- name: Set snapshot id
69+
- name: Set snapshot id for LUN
7070
ansible.builtin.set_fact:
7171
vol_snapshot_id: "{{ result.snapshot_details.id }}"
7272

playbooks/modules/snapshotschedule.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@
157157
id: "{{ id }}"
158158
state: "{{ state_absent }}"
159159

160-
- name: Delete snapshot schedule using name
160+
- name: Delete snapshot schedule using name for day
161161
dellemc.unity.snapshotschedule:
162162
unispherehost: "{{ unispherehost }}"
163163
validate_certs: "{{ validate_certs }}"
@@ -166,7 +166,7 @@
166166
name: "Ansible_Every_Day_Testing"
167167
state: "{{ state_absent }}"
168168

169-
- name: Delete snapshot schedule using name
169+
- name: Delete snapshot schedule using name for N days
170170
dellemc.unity.snapshotschedule:
171171
unispherehost: "{{ unispherehost }}"
172172
validate_certs: "{{ validate_certs }}"
@@ -175,7 +175,7 @@
175175
name: "Ansible_Every_N_Day_Testing"
176176
state: "{{ state_absent }}"
177177

178-
- name: Delete snapshot schedule using name
178+
- name: Delete snapshot schedule using name for week
179179
dellemc.unity.snapshotschedule:
180180
unispherehost: "{{ unispherehost }}"
181181
validate_certs: "{{ validate_certs }}"
@@ -184,7 +184,7 @@
184184
name: "Ansible_Every_Week_Testing"
185185
state: "{{ state_absent }}"
186186

187-
- name: Delete snapshot schedule using name
187+
- name: Delete snapshot schedule using name for month
188188
dellemc.unity.snapshotschedule:
189189
unispherehost: "{{ unispherehost }}"
190190
validate_certs: "{{ validate_certs }}"

0 commit comments

Comments
 (0)