-
Notifications
You must be signed in to change notification settings - Fork 73
Add IniBuilder #442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add IniBuilder #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a detailed look yet. But looks good.
I think we can keep it without a feature guard for now.
Would you mind adding documentation in the And thanks again for contributing! |
Yep, I can add a guide for that. Where do you think it should go? |
c43e8b6
to
7862694
Compare
08634cb
to
6e2c008
Compare
Seems the ini builder API didn't exist until 8.2. I've added compile gates to |
Guess you could pass that in here: Line 177 in cafaecc
See windows build: Line 53 in cafaecc
|
af9e073
to
9d8436f
Compare
I did some restructuring of the build file to include an ApiVersion enum which can be used for managing both the cfg flag names and C define names in the stacked form it was using before, so we can do |
5d7b961
to
47b170d
Compare
5334031
to
7a0495c
Compare
This might only be useful in combination with the
embed
feature so it may make sense to gate this behind that feature, but it doesn't depend on it in any way--it can exist without it. I left the feature-gating out, but I could change that if you prefer.