Skip to content

chore(bindings): add tooling to generate docsrs_bindings.rs #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

Xenira
Copy link
Collaborator

@Xenira Xenira commented Jun 12, 2025

Refs: #443

@Xenira Xenira linked an issue Jun 12, 2025 that may be closed by this pull request
@Xenira Xenira force-pushed the 443-automate-docsrs_bindingsrs-generation branch from 2be02c1 to a6f9590 Compare June 12, 2025 17:47
@Xenira Xenira marked this pull request as draft June 12, 2025 17:49
@Xenira Xenira force-pushed the 443-automate-docsrs_bindingsrs-generation branch 2 times, most recently from bd62014 to e76363d Compare June 12, 2025 18:11
@Xenira Xenira marked this pull request as ready for review June 12, 2025 18:13
@Xenira Xenira force-pushed the 443-automate-docsrs_bindingsrs-generation branch 4 times, most recently from 27ce65c to 47d6c75 Compare June 12, 2025 18:26
Copy link
Collaborator

@ptondereau ptondereau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work BTW! It was a struggle point in the past 😅

@Xenira Xenira force-pushed the 443-automate-docsrs_bindingsrs-generation branch 2 times, most recently from 0e66ef4 to 763523a Compare June 12, 2025 18:34
@Xenira
Copy link
Collaborator Author

Xenira commented Jun 12, 2025

Great work BTW! It was a struggle point in the past 😅

Thanks. Yeah came up a lot 🫤

@Xenira Xenira force-pushed the 443-automate-docsrs_bindingsrs-generation branch from 763523a to e2cb354 Compare June 12, 2025 18:42
@Xenira Xenira force-pushed the 443-automate-docsrs_bindingsrs-generation branch from e2cb354 to 0e1752d Compare June 12, 2025 18:47
@Xenira Xenira merged commit f4fd27e into master Jun 12, 2025
36 checks passed
@Xenira Xenira deleted the 443-automate-docsrs_bindingsrs-generation branch June 12, 2025 19:00
@coveralls
Copy link

coveralls commented Jun 12, 2025

Pull Request Test Coverage Report for Build 15618572899

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.105%

Totals Coverage Status
Change from base Build 15596794337: 0.0%
Covered Lines: 829
Relevant Lines: 3928

💛 - Coveralls

@Qard
Copy link
Contributor

Qard commented Jun 13, 2025

I think this might have an architecture problem. I updated #442, #444 and #445 with it and all had a few slight changes which appear to be unrelated to the PR changes and look an awful lot like architectural differences--differently sized types, mainly.

@Xenira
Copy link
Collaborator Author

Xenira commented Jun 13, 2025

I think this might have an architecture problem. I updated #442, #444 and #445 with it and all had a few slight changes which appear to be unrelated to the PR changes and look an awful lot like architectural differences--differently sized types, mainly.

@Qard Yes, you are right. Can you try adding a --platform linux/amd64 to the docker build command in tools/update_bindings.sh. In my testing I got the same diff as you when building for arm.

@Qard
Copy link
Contributor

Qard commented Jun 14, 2025

Yep, that appears to do it. I pushed an update to #444 which includes that change and the bindings look correct now. 🙂

Xenira pushed a commit that referenced this pull request Jun 14, 2025
@davidcole1340 davidcole1340 mentioned this pull request Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate docsrs_bindings.rs generation
4 participants