Skip to content

[Internal] Update SDK to latest OpenAPI spec #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Conversation

tanmay-db
Copy link
Contributor

What changes are proposed in this pull request?

Update SDK to latest OpenAPI spec

How is this tested?

N/A

@tanmay-db tanmay-db force-pushed the update-sdk-24april branch from 06de5cb to 7447a2d Compare April 24, 2025 14:51
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 14:51 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 14:51 — with GitHub Actions Inactive
@tanmay-db tanmay-db requested review from rauchy and mgyucht April 24, 2025 15:00
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking changes for vector search are caused by migration to OpenAPI generator. One small nit on the changelog.

* [Breaking] Changed `CreateIndex` method for [w.VectorSearchIndexes](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#VectorSearchIndexesAPI) workspace-level service to return [vectorsearch.VectorIndex](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#VectorIndex).
* [Breaking] Changed `DeleteDataVectorIndex` method for [w.VectorSearchIndexes](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#VectorSearchIndexesAPI) workspace-level service . HTTP method/verb has changed.
* [Breaking] Changed `DeleteDataVectorIndex` method for [w.VectorSearchIndexes](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#VectorSearchIndexesAPI) workspace-level service with new required argument order.
* [Breaking] Changed [vectorsearch.List](https://pkg.go.dev/github.com/databricks/databricks-sdk-go/service/vectorsearch#List) to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hectorcast-db this message seems a bit off; is this known?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all the vector search changes, the list related changes are covered in below point regarding DataArray (ListValueList), not sure where this is coming from. Going to remove this line and follow up with release.

Copy link
Contributor

@hectorcast-db hectorcast-db Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I can guess what it is.
I approved the following change:
Screenshot 2025-04-25 at 07 57 09

A list of list of strings seems something that we did not considered (and cannot be expressed in protobuf). We should double check, but I would not fix this, since generated specs and new APIs won't have this.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 16:37 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-go

Inputs:

  • PR number: 1209
  • Commit SHA: 9eca67ecf17ee79fbc04e32d8db85f1e0a8f4526

Checks will be approved automatically on success.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 16:37 — with GitHub Actions Inactive
@tanmay-db tanmay-db added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit e7f1736 Apr 24, 2025
15 checks passed
@tanmay-db tanmay-db deleted the update-sdk-24april branch April 24, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants