Skip to content

[Internal] Update SDK to latest OpenAPI Spec #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Conversation

tanmay-db
Copy link
Contributor

What changes are proposed in this pull request?

Update SDK to latest OpenAPI specification

How is this tested?

N/A

@tanmay-db tanmay-db force-pushed the update-sdk-24april branch from b7b1c36 to 64a37eb Compare April 24, 2025 14:59
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 14:59 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 15:00 — with GitHub Actions Inactive
@tanmay-db tanmay-db requested review from rauchy and mgyucht April 24, 2025 15:00
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo changelog nit.

* [Breaking] Changed `createIndex()` method for `workspaceClient.vectorSearchIndexes()` service to return `com.databricks.sdk.service.vectorsearch.VectorIndex` class.
* [Breaking] Changed `deleteDataVectorIndex()` method for `workspaceClient.vectorSearchIndexes()` service . HTTP method/verb has changed.
* [Breaking] Changed `deleteDataVectorIndex()` method for `workspaceClient.vectorSearchIndexes()` service with new required argument order.
* [Breaking] Changed `com.databricks.sdk.service.vectorsearch.List` class to.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here: the changelog seems off.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 16:38 — with GitHub Actions Inactive
Copy link

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/sdk-java

Inputs:

  • PR number: 436
  • Commit SHA: d6ffc03096d275cf93b3446f1d636623a847887e

Checks will be approved automatically on success.

@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 24, 2025 16:38 — with GitHub Actions Inactive
@tanmay-db tanmay-db added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 37518a4 Apr 24, 2025
15 checks passed
@tanmay-db tanmay-db deleted the update-sdk-24april branch April 24, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants