characterize-psf with larger datasets
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34.
I found that
max_pool3dwas the memory bottleneck, requesting more than 141 GB of our memory for daxi volumes (overfilling an H200).Here I'm working around it by computing
max_pool3don the CPU. For smaller datasets, I found the CPU to be quite fast.Related aside (should not block this merge): After removing this GPU memory bottleneck, I found that the next bottleneck is the fitting routine, which stalls on some beads. The
tqdmprogress bar shows steady progress on many beads, but very slow progress on some (likely not-very-gaussian) beads. @ieivanov I suspect that I'm not doing a good job filtering beads, and I'll chat with you about your routine for picking peak-fitting parameters.